Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamReader arguments in NeuropixelsV1Helper.ParseAdcCalibrationFile() and ParseGainCalibrationFile() should be a path #283

Closed
jonnew opened this issue Sep 3, 2024 · 2 comments
Assignees
Milestone

Comments

@jonnew
Copy link
Member

jonnew commented Sep 3, 2024

The file input argument in the following functions:

https://github.com/open-ephys/onix-bonsai-onix1/blob/3fdcec67f5f5d548ddf9125d7859565b55a48d08/OpenEphys.Onix1/NeuropixelsV1Helper.cs#L21

https://github.com/open-ephys/onix-bonsai-onix1/blob/3fdcec67f5f5d548ddf9125d7859565b55a48d08/OpenEphys.Onix1/NeuropixelsV1Helper.cs#L65

should either be a FileStream or a string indicating a path. StreamReader is to general because calibration data is always provided in a file and this function call expects to start from the beginning of the stream. This will require a change in the public API.

@bparks13
Copy link
Member

bparks13 commented Sep 5, 2024

These methods have been marked as [Obsolete] in #291, but will not be modified/removed until 1.0.0.

@jonnew
Copy link
Member Author

jonnew commented Oct 15, 2024

This will be addressed in #304. Im closing since in reality its already addressed in #291.

@jonnew jonnew closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants