Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix units in Rhs2116DataFrame xml comment #355

Open
cjsha opened this issue Oct 29, 2024 · 1 comment
Open

Fix units in Rhs2116DataFrame xml comment #355

cjsha opened this issue Oct 29, 2024 · 1 comment
Assignees
Milestone

Comments

@cjsha
Copy link
Member

cjsha commented Oct 29, 2024

I'm guessing the mv needs to be µV.

The offending lines:

/// V_electrode (mV) = -19.23 mV × (ADC result – 512)

/// V_electrode (uV) = 0.195 µV × (ADC result – 32768)

I linked the second line as well because we use "uV" in the first instance and "µV" in the second instance.

This screenshot shows what I'm referring to. Look at the (micro-/milli-)Volt units.

image

@jonnew
Copy link
Member

jonnew commented Nov 4, 2024

The only change that seems to be required is that in the DCData description, last sentence should be "To convert to millivolts"

Also, while we are at it, remove dashes between micro-volts and milli-volts.

@jonnew jonnew added this to the 0.5.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants