Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product prefill configuration modal: integrate with backend #4693

Open
9 tasks done
Tracked by #4266
stevenbal opened this issue Sep 23, 2024 · 0 comments · May be fixed by #4799
Open
9 tasks done
Tracked by #4266

Product prefill configuration modal: integrate with backend #4693

stevenbal opened this issue Sep 23, 2024 · 0 comments · May be fixed by #4799
Assignees
@stevenbal
Labels
enhancement owner: den-haag
Milestone
Release 3.0

Comments

@stevenbal
Copy link
Contributor

stevenbal commented Sep 23, 2024 •
edited by sergei-maertens
Loading

Remaining points from #4610 (issue #4608) to ensure the PR doesn't hang for too long

  • once https://github.com/open-formulieren/open-forms/pull/4620/files is merged
    • implement save
    • uses objecttypeUuid instead of objecttype (which is used by the registration endpoint and in the ObjectType fields)
  • modal objecttype select menuPlacement makes it open top, leaving 5th option under header
  • implement copy from button
  • default selected objecttype doesnt cause options to be populated because wrong objecttype is loaded?
  • check if on error data is still filled in
  • failure when fetching objecttypes doesnt go away when switching group
  • add storybook for copy button
@stevenbal stevenbal added this to the Release 3.0 milestone Sep 23, 2024
@stevenbal stevenbal self-assigned this Sep 23, 2024
@stevenbal stevenbal mentioned this issue Sep 23, 2024
Closed
stevenbal added a commit that referenced this issue Sep 23, 2024
@stevenbal
✨ [#4608] Modal for Objects API prefill options
42cafd1 
this is the initial implementation, it is not yet fully functional, since it relies on backend changes that are not merged yet.
It will be connected with the backend in #4693
@stevenbal stevenbal mentioned this issue Sep 23, 2024
Open
8 tasks
stevenbal added a commit that referenced this issue Sep 30, 2024
@stevenbal
✨ [#4608] Modal for Objects API prefill options
9b8f5ed 
this is the initial implementation, it is not yet fully functional, since it relies on backend changes that are not merged yet.
It will be connected with the backend in #4693
stevenbal added a commit that referenced this issue Sep 30, 2024
@stevenbal
✨ [#4608] Modal for Objects API prefill options
a06ddc1 
this is the initial implementation, it is not yet fully functional, since it relies on backend changes that are not merged yet.
It will be connected with the backend in #4693
sergei-maertens pushed a commit that referenced this issue Oct 7, 2024
@stevenbal @sergei-maertens
✨ [#4608] Modal for Objects API prefill options
49adede 
this is the initial implementation, it is not yet fully functional, since it relies on backend changes that are not merged yet.
It will be connected with the backend in #4693
sergei-maertens pushed a commit that referenced this issue Oct 7, 2024
@stevenbal @sergei-maertens
✨ [#4608] Modal for Objects API prefill options
0724c38 
this is the initial implementation, it is not yet fully functional, since it relies on backend changes that are not merged yet.
It will be connected with the backend in #4693
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@stevenbal @robinmolen
✨ [#4608] Modal for Objects API prefill options
98a1287 
this is the initial implementation, it is not yet fully functional, since it relies on backend changes that are not merged yet.
It will be connected with the backend in #4693
stevenbal added a commit that referenced this issue Oct 28, 2024
@stevenbal
👽 [#4693] Integrate Objects API prefill modal with backend
44f5427
stevenbal added a commit that referenced this issue Oct 28, 2024
@stevenbal
👽 [#4693] Integrate Objects API prefill modal with backend
c725d4c
@stevenbal stevenbal linked a pull request Oct 28, 2024 that will close this issue
Draft
9 tasks
stevenbal added a commit that referenced this issue Oct 28, 2024
@stevenbal
👽 [#4693] Integrate Objects API prefill modal with backend
7436b8f
stevenbal added a commit that referenced this issue Oct 28, 2024
@stevenbal
👽 [#4693] Integrate Objects API prefill modal with backend
5147a2a
stevenbal added a commit that referenced this issue Oct 28, 2024
@stevenbal
👽 [#4693] Integrate Objects API prefill modal with backend
d68c21d
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
👽 [#4693] Integrate Objects API prefill modal with backend
37cdaf3
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
👽 [#4693] Integrate Objects API prefill modal with backend
662d10e
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
✨ [#4693] Add copy button for Objects API prefill config
4c409f2 
that allows the user to copy the configuration used by the Form's registration backend
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
✅ [#4693] Add story for Objects API prefill copy button
5332c87
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
✨ [#4693] Add copy button for Objects API prefill config
49af4a9 
that allows the user to copy the configuration used by the Form's registration backend
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
✨ [#4693] Add copy button for Objects API prefill config
175af2c 
that allows the user to copy the configuration used by the Form's registration backend
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
🌐 [#4693] Compile JS translations
daa4668
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
💄 [#4693] Fix select menu overflow issues in prefill modal
efb307d
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
👽 [#4693] Integrate Objects API prefill modal with backend
4f021d4
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
✨ [#4693] Add copy button for Objects API prefill config
6a7f4d1 
that allows the user to copy the configuration used by the Form's registration backend
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
🌐 [#4693] Compile JS translations
90ad52d
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
💄 [#4693] Fix select menu overflow issues in prefill modal
f9fda81
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
👌 [#4693] Process PR feedback
24b7838 
* remove unnecessary prefill prefix from options in javascript code
* remove trailing comments
* use variable for computed name in VariableMapping
* add dropdown to select a registration backend instead of always picking first
* also copy variablesmapping when clicking copy button
stevenbal added a commit that referenced this issue Oct 29, 2024
@stevenbal
👌 [#4693] Process PR feedback
0b8256e 
* remove unnecessary prefill prefix from options in javascript code
* remove trailing comments
* use variable for computed name in VariableMapping
* add dropdown to select a registration backend instead of always picking first
* also copy variablesmapping when clicking copy button
stevenbal added a commit that referenced this issue Nov 4, 2024
@stevenbal
👽 [#4693] Integrate Objects API prefill modal with backend
3640670
stevenbal added a commit that referenced this issue Nov 4, 2024
@stevenbal
✨ [#4693] Add copy button for Objects API prefill config
3b08bdb 
that allows the user to copy the configuration used by the Form's registration backend
stevenbal added a commit that referenced this issue Nov 4, 2024
@stevenbal
💄 [#4693] Fix select menu overflow issues in prefill modal
b185541
stevenbal added a commit that referenced this issue Nov 4, 2024
@stevenbal
👌 [#4693] Process PR feedback
327df25 
* remove unnecessary prefill prefix from options in javascript code
* remove trailing comments
* use variable for computed name in VariableMapping
* add dropdown to select a registration backend instead of always picking first
* also copy variablesmapping when clicking copy button
* use setValues to set formik values at once, instead of multiple calls of setFieldValue
stevenbal added a commit that referenced this issue Nov 4, 2024
@stevenbal
🌐 [#4693] Compile JS translations
5e646cc
sergei-maertens pushed a commit that referenced this issue Nov 12, 2024
@stevenbal @sergei-maertens
👽 [#4693] Integrate Objects API prefill modal with backend
50d8129
sergei-maertens pushed a commit that referenced this issue Nov 12, 2024
@stevenbal @sergei-maertens
✨ [#4693] Add copy button for Objects API prefill config
291b6a7 
that allows the user to copy the configuration used by the Form's registration backend
sergei-maertens pushed a commit that referenced this issue Nov 12, 2024
@stevenbal @sergei-maertens
💄 [#4693] Fix select menu overflow issues in prefill modal
3caae1d
sergei-maertens pushed a commit that referenced this issue Nov 12, 2024
@stevenbal @sergei-maertens
👌 [#4693] Process PR feedback
60087ca 
* remove unnecessary prefill prefix from options in javascript code
* remove trailing comments
* use variable for computed name in VariableMapping
* add dropdown to select a registration backend instead of always picking first
* also copy variablesmapping when clicking copy button
* use setValues to set formik values at once, instead of multiple calls of setFieldValue
sergei-maertens pushed a commit that referenced this issue Nov 12, 2024
@stevenbal @sergei-maertens
🌐 [#4693] Compile JS translations
33836d3
sergei-maertens added a commit that referenced this issue Nov 12, 2024
@sergei-maertens
🏷️ [#4693] Fix AttributeSelect prop types
dd74797
sergei-maertens added a commit that referenced this issue Nov 12, 2024
@sergei-maertens
🎨 [#4693] Don't show copy button if no backends are available
a1cbd51
sergei-maertens added a commit that referenced this issue Nov 12, 2024
@sergei-maertens
💄 [#4693] Use portalling to prevent hidden overflow of react-select menu
8e23cf3
sergei-maertens pushed a commit that referenced this issue Nov 18, 2024
@stevenbal @sergei-maertens
👽 [#4693] Integrate Objects API prefill modal with backend
51bdf97
sergei-maertens pushed a commit that referenced this issue Nov 18, 2024
@stevenbal @sergei-maertens
✨ [#4693] Add copy button for Objects API prefill config
a9b61d2 
that allows the user to copy the configuration used by the Form's registration backend
sergei-maertens pushed a commit that referenced this issue Nov 18, 2024
@stevenbal @sergei-maertens
💄 [#4693] Fix select menu overflow issues in prefill modal
feab1eb
sergei-maertens pushed a commit that referenced this issue Nov 18, 2024
@stevenbal @sergei-maertens
👌 [#4693] Process PR feedback
103f535 
* remove unnecessary prefill prefix from options in javascript code
* remove trailing comments
* use variable for computed name in VariableMapping
* add dropdown to select a registration backend instead of always picking first
* also copy variablesmapping when clicking copy button
* use setValues to set formik values at once, instead of multiple calls of setFieldValue
sergei-maertens pushed a commit that referenced this issue Nov 18, 2024
@stevenbal @sergei-maertens
🌐 [#4693] Compile JS translations
1ecf1be
sergei-maertens added a commit that referenced this issue Nov 18, 2024
@sergei-maertens
🏷️ [#4693] Fix AttributeSelect prop types
f94f7e1
sergei-maertens added a commit that referenced this issue Nov 18, 2024
@sergei-maertens
🎨 [#4693] Don't show copy button if no backends are available
951fd64
sergei-maertens added a commit that referenced this issue Nov 18, 2024
@sergei-maertens
💄 [#4693] Use portalling to prevent hidden overflow of react-select menu
4716f4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenbal stevenbal

Labels
enhancement owner: den-haag
Projects
Development
Status: Implemented
Milestone
Release 3.0
Development

Successfully merging a pull request may close this issue.

👽 [#4693] Integrate Objects API prefill modal with backend open-formulieren/open-forms
1 participant
@stevenbal