teams: smoother survey repository querying (fixes #8975) (#8924)

Author: dogi

app/build.gradle

@@ -9,8 +9,8 @@ android {
         applicationId "org.ole.planet.myplanet"
         minSdk = 26
         targetSdk = 36
-        versionCode = 3697
-        versionName = "0.36.97"
+        versionCode = 3698
+        versionName = "0.36.98"
         ndkVersion = '26.3.11579264'
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true

app/src/main/java/org/ole/planet/myplanet/repository/SurveyRepository.kt

@@ -1,9 +1,16 @@
 package org.ole.planet.myplanet.repository
 
 import org.ole.planet.myplanet.model.RealmStepExam
+import org.ole.planet.myplanet.ui.survey.SurveyInfo
 
 interface SurveyRepository {
     suspend fun getTeamOwnedSurveys(teamId: String?): List<RealmStepExam>
     suspend fun getAdoptableTeamSurveys(teamId: String?): List<RealmStepExam>
     suspend fun getIndividualSurveys(): List<RealmStepExam>
+    suspend fun getSurveyInfos(
+        isTeam: Boolean,
+        teamId: String?,
+        userId: String?,
+        surveys: List<RealmStepExam>
+    ): Map<String, SurveyInfo>
 }

app/src/main/java/org/ole/planet/myplanet/repository/SurveyRepositoryImpl.kt

@@ -1,13 +1,21 @@
 package org.ole.planet.myplanet.repository
 
+import android.content.Context
+import dagger.hilt.android.qualifiers.ApplicationContext
+import io.realm.Sort
 import javax.inject.Inject
 import org.json.JSONException
 import org.json.JSONObject
+import org.ole.planet.myplanet.R
 import org.ole.planet.myplanet.datamanager.DatabaseService
 import org.ole.planet.myplanet.model.RealmStepExam
 import org.ole.planet.myplanet.model.RealmSubmission
+import org.ole.planet.myplanet.ui.survey.SurveyInfo
+import org.ole.planet.myplanet.utilities.TimeUtils.formatDate
+import org.ole.planet.myplanet.utilities.TimeUtils.getFormattedDateWithTime
 
 class SurveyRepositoryImpl @Inject constructor(
+    @ApplicationContext private val context: Context,
     databaseService: DatabaseService
 ) : RealmRepository(databaseService), SurveyRepository {
 
@@ -77,4 +85,44 @@ class SurveyRepositoryImpl @Inject constructor(
             null
         }
     }
+
+    override suspend fun getSurveyInfos(
+        isTeam: Boolean,
+        teamId: String?,
+        userId: String?,
+        surveys: List<RealmStepExam>
+    ): Map<String, SurveyInfo> {
+        val surveyIds = surveys.map { it.id }
+        val submissions = queryList(RealmSubmission::class.java) {
+            `in`("parentId", surveyIds.toTypedArray())
+        }
+        val surveyInfos = mutableMapOf<String, SurveyInfo>()
+        for (survey in surveys) {
+            val surveyId = survey.id ?: continue
+            val submissionCount = if (isTeam) {
+                submissions.count { it.parentId == surveyId && it.membershipDoc?.teamId == teamId }.toString()
+            } else {
+                submissions.count { it.parentId == surveyId && it.userId == userId }.toString()
+            }
+            val lastSubmissionDate = if (isTeam) {
+                submissions.filter { it.parentId == surveyId && it.membershipDoc?.teamId == teamId }
+                    .maxByOrNull { it.startTime }?.startTime?.let { getFormattedDateWithTime(it) } ?: ""
+            } else {
+                submissions.filter { it.parentId == surveyId && it.userId == userId }
+                    .maxByOrNull { it.startTime }?.startTime?.let { getFormattedDateWithTime(it) } ?: ""
+            }
+            val creationDate = survey.createdDate.let { formatDate(it, "MMM dd, yyyy") } ?: ""
+            surveyInfos[surveyId] = SurveyInfo(
+                surveyId = surveyId,
+                submissionCount = context.resources.getQuantityString(
+                    R.plurals.survey_taken_count,
+                    submissionCount.toInt(),
+                    submissionCount.toInt()
+                ),
+                lastSubmissionDate = lastSubmissionDate,
+                creationDate = creationDate
+            )
+        }
+        return surveyInfos
+    }
 }

app/src/main/java/org/ole/planet/myplanet/ui/survey/AdapterSurvey.kt

@@ -34,7 +34,8 @@ class AdapterSurvey(
     val teamId: String?,
     private val surveyAdoptListener: SurveyAdoptListener,
     private val settings: SharedPreferences,
-    private val userProfileDbHandler: UserProfileDbHandler
+    private val userProfileDbHandler: UserProfileDbHandler,
+    private val surveyInfoMap: Map<String, SurveyInfo>
 ) : RecyclerView.Adapter<AdapterSurvey.ViewHolderSurvey>() {
     private var examList: List<RealmStepExam> = emptyList()
     private var listener: OnHomeItemClickListener? = null
@@ -187,13 +188,10 @@ class AdapterSurvey(
                     startSurvey.visibility = View.GONE
                 }
 
-                tvNoSubmissions.text = when {
-                    isTeam -> getNoOfSubmissionByTeam(teamId, exam.id, mRealm)
-                    else -> getNoOfSubmissionByUser(exam.id, exam.courseId, userId, mRealm)
-                }
-                tvDateCompleted.text = getRecentSubmissionDate(exam.id, exam.courseId, userId, mRealm)
-                val creationTime = exam.id?.let { RealmStepExam.getSurveyCreationTime(it, mRealm) }
-                tvDate.text = creationTime?.let { formatDate(it, "MMM dd, yyyy") } ?: ""
+                val surveyInfo = surveyInfoMap[exam.id]
+                tvNoSubmissions.text = surveyInfo?.submissionCount ?: ""
+                tvDateCompleted.text = surveyInfo?.lastSubmissionDate ?: ""
+                tvDate.text = surveyInfo?.creationDate ?: ""
             }
         }
 

app/src/main/java/org/ole/planet/myplanet/ui/survey/SurveyFragment.kt

@@ -46,6 +46,7 @@ class SurveyFragment : BaseRecyclerFragment<RealmStepExam?>(), SurveyAdoptListen
     private val serverUrlMapper = ServerUrlMapper()
     private var loadSurveysJob: Job? = null
     private var currentSurveys: List<RealmStepExam> = emptyList()
+    private val surveyInfoMap = mutableMapOf<String, SurveyInfo>()
 
     @Inject
     lateinit var syncManager: SyncManager
@@ -81,7 +82,8 @@ class SurveyFragment : BaseRecyclerFragment<RealmStepExam?>(), SurveyAdoptListen
             teamId,
             this,
             settings,
-            profileDbHandler
+            profileDbHandler,
+            surveyInfoMap
         )
         prefManager = SharedPrefManager(requireContext())
 
@@ -267,14 +269,22 @@ class SurveyFragment : BaseRecyclerFragment<RealmStepExam?>(), SurveyAdoptListen
     fun updateAdapterData(isTeamShareAllowed: Boolean? = null) {
         val useTeamShareAllowed = isTeamShareAllowed ?: currentIsTeamShareAllowed
         currentIsTeamShareAllowed = useTeamShareAllowed
-
+        val userProfileModel = profileDbHandler.userModel
         loadSurveysJob?.cancel()
         loadSurveysJob = launchWhenViewIsReady {
             currentSurveys = when {
                 isTeam && useTeamShareAllowed -> surveyRepository.getAdoptableTeamSurveys(teamId)
                 isTeam -> surveyRepository.getTeamOwnedSurveys(teamId)
                 else -> surveyRepository.getIndividualSurveys()
             }
+            val surveyInfos = surveyRepository.getSurveyInfos(
+                isTeam,
+                teamId,
+                userProfileModel?.id,
+                currentSurveys
+            )
+            surveyInfoMap.clear()
+            surveyInfoMap.putAll(surveyInfos)
             applySearchFilter()
         }
     }

app/src/main/java/org/ole/planet/myplanet/ui/survey/SurveyInfo.kt

@@ -0,0 +1,8 @@
+package org.ole.planet.myplanet.ui.survey
+
+data class SurveyInfo(
+    val surveyId: String,
+    val submissionCount: String,
+    val lastSubmissionDate: String,
+    val creationDate: String
+)