sync: smoother manager scoping (fixes #9031) (#9009)

Author: dogi

app/build.gradle

@@ -9,8 +9,8 @@ android {
         applicationId "org.ole.planet.myplanet"
         minSdk = 26
         targetSdk = 36
-        versionCode = 3718
-        versionName = "0.37.18"
+        versionCode = 3719
+        versionName = "0.37.19"
         ndkVersion = '26.3.11579264'
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true

app/src/main/java/org/ole/planet/myplanet/di/ServiceModule.kt

@@ -43,9 +43,10 @@ object ServiceModule {
         databaseService: DatabaseService,
         @AppPreferences preferences: SharedPreferences,
         apiInterface: ApiInterface,
-        improvedSyncManager: Lazy<ImprovedSyncManager>
+        improvedSyncManager: Lazy<ImprovedSyncManager>,
+        @ApplicationScope scope: CoroutineScope
     ): SyncManager {
-        return SyncManager(context, databaseService, preferences, apiInterface, improvedSyncManager)
+        return SyncManager(context, databaseService, preferences, apiInterface, improvedSyncManager, scope)
     }
 
     @Provides

app/src/main/java/org/ole/planet/myplanet/service/SyncManager.kt

@@ -37,6 +37,7 @@ import org.ole.planet.myplanet.datamanager.ApiInterface
 import org.ole.planet.myplanet.datamanager.DatabaseService
 import org.ole.planet.myplanet.datamanager.ManagerSync
 import org.ole.planet.myplanet.di.AppPreferences
+import org.ole.planet.myplanet.di.ApplicationScope
 import org.ole.planet.myplanet.model.RealmMeetup.Companion.insert
 import org.ole.planet.myplanet.model.RealmMyCourse.Companion.insertMyCourses
 import org.ole.planet.myplanet.model.RealmMyCourse.Companion.saveConcatenatedLinksToPrefs
@@ -64,15 +65,15 @@ class SyncManager @Inject constructor(
     private val databaseService: DatabaseService,
     @AppPreferences private val settings: SharedPreferences,
     private val apiInterface: ApiInterface,
-    private val improvedSyncManager: Lazy<ImprovedSyncManager>
+    private val improvedSyncManager: Lazy<ImprovedSyncManager>,
+    @ApplicationScope private val syncScope: CoroutineScope
 ) {
     private var td: Thread? = null
     lateinit var mRealm: Realm
     private var isSyncing = false
     private val stringArray = arrayOfNulls<String>(4)
     private var listener: SyncListener? = null
     private var backgroundSync: Job? = null
-    private val syncScope = CoroutineScope(Dispatchers.IO + SupervisorJob())
     private var betaSync = false
     private val improvedSyncInitialized = AtomicBoolean(false)