feat: Offload storage clearing to background thread to prevent ANR

Refactored `clearInternalStorage` in `SyncActivity` to be a `suspend` function, moving the file deletion logic to a background thread using `withContext(Dispatchers.IO)`.

This prevents the main thread from being blocked during the potentially long-running storage cleanup process, resolving a critical ANR risk.

Additionally, the `StrictMode` policy was strengthened to include `penaltyDeath()` in debug builds. This will proactively catch similar main-thread I/O regressions in the future by causing the app to crash during development, making such issues impossible to ignore. A race condition was also fixed by ensuring the sync process only starts after the storage clearing is complete.

Author: google-labs-jules[bot]

app/src/main/java/org/ole/planet/myplanet/MainApplication.kt

@@ -229,6 +229,7 @@ class MainApplication : Application(), Application.ActivityLifecycleCallbacks {
                 .detectDiskWrites()
                 .detectNetwork()
                 .penaltyLog()
+                .penaltyDeath()
                 .build()
             StrictMode.setThreadPolicy(threadPolicy)
         }

app/src/main/java/org/ole/planet/myplanet/ui/sync/SyncActivity.kt

@@ -230,13 +230,15 @@ abstract class SyncActivity : ProcessUserDataActivity(), SyncListener, CheckVers
             .show()
     }
 
-    private fun clearInternalStorage() {
-        val myDir = File(FileUtils.getOlePath(this))
-        if (myDir.isDirectory) {
-            val children = myDir.list()
-            if (children != null) {
-                for (i in children.indices) {
-                    File(myDir, children[i]).delete()
+    private suspend fun clearInternalStorage() {
+        withContext(Dispatchers.IO) {
+            val myDir = File(FileUtils.getOlePath(this@SyncActivity))
+            if (myDir.isDirectory) {
+                val children = myDir.list()
+                if (children != null) {
+                    for (i in children.indices) {
+                        File(myDir, children[i]).delete()
+                    }
                 }
             }
         }
@@ -728,20 +730,27 @@ abstract class SyncActivity : ProcessUserDataActivity(), SyncListener, CheckVers
         processedUrl = saveConfigAndContinue(dialog, url, isAlternativeUrl, defaultUrl)
         if (TextUtils.isEmpty(processedUrl)) return
         isSync = true
-        if (checkPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE) && settings.getBoolean("firstRun", true)) {
-            clearInternalStorage()
-        }
-        Service(this).isPlanetAvailable(object : PlanetAvailableListener {
-            override fun isAvailable() {
-                Service(context).checkVersion(this@SyncActivity, settings)
-            }
-            override fun notAvailable() {
-                if (!isFinishing) {
-                    syncFailed = true
-                    showAlert(context, "Error", getString(R.string.planet_server_not_reachable))
+        val startSyncFlow = {
+            Service(this).isPlanetAvailable(object : PlanetAvailableListener {
+                override fun isAvailable() {
+                    Service(context).checkVersion(this@SyncActivity, settings)
+                }
+                override fun notAvailable() {
+                    if (!isFinishing) {
+                        syncFailed = true
+                        showAlert(context, "Error", getString(R.string.planet_server_not_reachable))
+                    }
                 }
+            })
+        }
+        if (checkPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE) && settings.getBoolean("firstRun", true)) {
+            lifecycleScope.launch {
+                clearInternalStorage()
+                startSyncFlow()
             }
-        })
+        } else {
+            startSyncFlow()
+        }
     }
 
     override fun onSuccess(success: String?) {