all: smoother notifications realm querying (fixes #8995) (#8957)

Author: dogi

app/build.gradle

@@ -9,8 +9,8 @@ android {
         applicationId "org.ole.planet.myplanet"
         minSdk = 26
         targetSdk = 36
-        versionCode = 3711
-        versionName = "0.37.11"
+        versionCode = 3712
+        versionName = "0.37.12"
         ndkVersion = '26.3.11579264'
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true

app/src/main/java/org/ole/planet/myplanet/MainApplication.kt

@@ -223,6 +223,15 @@ class MainApplication : Application(), Application.ActivityLifecycleCallbacks {
     }
 
     private fun setupStrictMode() {
+        if (BuildConfig.DEBUG) {
+            val threadPolicy = StrictMode.ThreadPolicy.Builder()
+                .detectDiskReads()
+                .detectDiskWrites()
+                .detectNetwork()
+                .penaltyLog()
+                .build()
+            StrictMode.setThreadPolicy(threadPolicy)
+        }
         val builder = VmPolicy.Builder()
         StrictMode.setVmPolicy(builder.build())
         builder.detectFileUriExposure()

app/src/main/java/org/ole/planet/myplanet/ui/dashboard/notification/NotificationsFragment.kt

@@ -102,86 +102,99 @@ class NotificationsFragment : Fragment() {
     }
 
     private fun handleNotificationClick(notification: RealmNotification) {
-        when (notification.type) {
-            "storage" -> {
-                val intent = Intent(ACTION_INTERNAL_STORAGE_SETTINGS)
-                startActivity(intent)
-            }
-            "survey" -> {
-                databaseService.withRealm { realm ->
-                    val currentStepExam = realm.where(RealmStepExam::class.java)
-                        .equalTo("name", notification.relatedId)
-                        .findFirst()
-                    if (currentStepExam != null && activity is OnHomeItemClickListener) {
+        viewLifecycleOwner.lifecycleScope.launch {
+            when (notification.type) {
+                "storage" -> {
+                    val intent = Intent(ACTION_INTERNAL_STORAGE_SETTINGS)
+                    startActivity(intent)
+                }
+                "survey" -> {
+                    val examId = withContext(Dispatchers.IO) {
+                        databaseService.withRealm { realm ->
+                            realm.where(RealmStepExam::class.java)
+                                .equalTo("name", notification.relatedId)
+                                .findFirst()?.id
+                        }
+                    }
+                    if (examId != null && activity is OnHomeItemClickListener) {
                         AdapterMySubmission.openSurvey(
                             activity as OnHomeItemClickListener,
-                            currentStepExam.id,
+                            examId,
                             false,
                             false,
                             "",
                         )
                     }
                 }
-            }
-            "task" -> {
-                databaseService.withRealm { realm ->
-                    val taskId = notification.relatedId
-                    val task = realm.where(RealmTeamTask::class.java)
-                        .equalTo("id", taskId)
-                        .findFirst()
-
-                    val linkJson = JSONObject(task?.link ?: "{}")
-                    val teamId = linkJson.optString("teams")
-                    if (teamId.isNotEmpty() && activity is OnHomeItemClickListener) {
-                        val teamObject = realm.where(RealmMyTeam::class.java)
-                            .equalTo("_id", teamId)
-                            .findFirst()
+                "task" -> {
+                    val teamDetails = withContext(Dispatchers.IO) {
+                        databaseService.withRealm { realm ->
+                            val taskId = notification.relatedId
+                            val task = realm.where(RealmTeamTask::class.java)
+                                .equalTo("id", taskId)
+                                .findFirst()
+                            val linkJson = JSONObject(task?.link ?: "{}")
+                            val teamId = linkJson.optString("teams")
+                            if (teamId.isNotEmpty()) {
+                                val teamObject = realm.where(RealmMyTeam::class.java)
+                                    .equalTo("_id", teamId)
+                                    .findFirst()
+                                Triple(teamId, teamObject?.name, teamObject?.type)
+                            } else {
+                                null
+                            }
+                        }
+                    }
+                    if (teamDetails != null && activity is OnHomeItemClickListener) {
+                        val (teamId, teamName, teamType) = teamDetails
                         val f = TeamDetailFragment.newInstance(
                             teamId = teamId,
-                            teamName = teamObject?.name ?: "",
-                            teamType = teamObject?.type ?: "",
+                            teamName = teamName ?: "",
+                            teamType = teamType ?: "",
                             isMyTeam = true,
                             navigateToPage = TasksPage,
                         )
-
                         (activity as OnHomeItemClickListener).openCallFragment(f)
                     }
                 }
-            }
-            "join_request" -> {
-                val joinRequestId = notification.relatedId
-                if (joinRequestId?.isNotEmpty() == true && activity is OnHomeItemClickListener) {
-                    val actualJoinRequestId = if (joinRequestId.startsWith("join_request_")) {
-                        joinRequestId.removePrefix("join_request_")
-                    } else {
-                        joinRequestId
+                "join_request" -> {
+                    val teamId = withContext(Dispatchers.IO) {
+                        val joinRequestId = notification.relatedId
+                        if (joinRequestId?.isNotEmpty() == true) {
+                            val actualJoinRequestId = if (joinRequestId.startsWith("join_request_")) {
+                                joinRequestId.removePrefix("join_request_")
+                            } else {
+                                joinRequestId
+                            }
+                            databaseService.withRealm { realm ->
+                                realm.where(RealmMyTeam::class.java)
+                                    .equalTo("_id", actualJoinRequestId)
+                                    .equalTo("docType", "request")
+                                    .findFirst()?.teamId
+                            }
+                        } else {
+                            null
+                        }
                     }
-                    databaseService.withRealm { realm ->
-                        val joinRequest = realm.where(RealmMyTeam::class.java)
-                            .equalTo("_id", actualJoinRequestId)
-                            .equalTo("docType", "request")
-                            .findFirst()
 
-                        val teamId = joinRequest?.teamId
-                        if (teamId?.isNotEmpty() == true) {
-                            val f = TeamDetailFragment()
-                            val b = Bundle()
-                            b.putString("id", teamId)
-                            b.putBoolean("isMyTeam", true)
-                            b.putString("navigateToPage", JoinRequestsPage.id)
-                            f.arguments = b
-                            (activity as OnHomeItemClickListener).openCallFragment(f)
-                        }
+                    if (teamId?.isNotEmpty() == true && activity is OnHomeItemClickListener) {
+                        val f = TeamDetailFragment()
+                        val b = Bundle()
+                        b.putString("id", teamId)
+                        b.putBoolean("isMyTeam", true)
+                        b.putString("navigateToPage", JoinRequestsPage.id)
+                        f.arguments = b
+                        (activity as OnHomeItemClickListener).openCallFragment(f)
                     }
                 }
+                "resource" -> {
+                    dashboardActivity.openMyFragment(ResourcesFragment())
+                }
             }
-            "resource" -> {
-                dashboardActivity.openMyFragment(ResourcesFragment())
-            }
-        }
 
-        if (!notification.isRead) {
-            markAsReadById(notification.id)
+            if (!notification.isRead) {
+                markAsReadById(notification.id)
+            }
         }
     }