Refactor: Optimize News Adapter and Fix Build Failures

This commit optimizes the performance of the news feed and resolves several issues that arose during the refactoring process.

**Performance Optimization:**

- Created a `NewsItem` data class to serve as a presentation model, decoupling the UI from Realm objects.
- Implemented a `NewsItemMapper` to handle the conversion from `RealmNews` to `NewsItem`, moving all expensive JSON parsing to a background coroutine.
- Refactored `AdapterNews`, `NewsFragment`, `ReplyActivity`, and `DiscussionListFragment` to use the new `NewsItem` model, ensuring `onBindViewHolder` is lightweight and performant.

**Bug Fixes:**

- **Fixes Build Failure:** Resolves a Kotlin compiler internal error by correcting method signature mismatches in the inheritance chain (`BaseNewsFragment`, `BaseTeamFragment`).
- **Fixes Functional Regression:** Re-implements the image download logic in `NewsFragment` that was accidentally removed during the refactor.
- **Fixes UI Thread Blocking:** Replaces a synchronous `executeTransaction` call in `AdapterNews` with a non-blocking, lifecycle-aware coroutine.
- **Fixes Compilation Error:** Corrects a type mismatch in a call to `NewsActions.deletePost` within `AdapterNews`.
- **Fixes Realm Threading Violation:** Ensures that all Realm instances are accessed on the thread they were created on by opening and closing new instances in background threads where necessary.

Author: google-labs-jules[bot]

app/src/main/java/org/ole/planet/myplanet/ui/news/AdapterNews.kt

@@ -155,9 +155,9 @@ class AdapterNews(
                 holder.itemView.findViewTreeLifecycleOwner()?.lifecycleScope?.launch {
                     val realmNews = withContext(Dispatchers.IO) {
                         var newsFromRealm: RealmNews? = null
-                        mRealm.executeTransaction {
-                            newsFromRealm =
-                                it.where(RealmNews::class.java).equalTo("id", news.id).findFirst()
+                        Realm.getDefaultInstance().use { realm ->
+                            newsFromRealm = realm.where(RealmNews::class.java).equalTo("id", news.id).findFirst()
+                            newsFromRealm = newsFromRealm?.let { realm.copyFromRealm(it) }
                         }
                         newsFromRealm
                     }

app/src/main/java/org/ole/planet/myplanet/ui/news/NewsFragment.kt

@@ -143,7 +143,7 @@ class NewsFragment : BaseNewsFragment() {
         }
 
         return filteredList.map { news ->
-            NewsItemMapper.map(news, mRealm, userCache)
+            NewsItemMapper.map(news, userCache)
         }
     }
 
@@ -170,7 +170,7 @@ class NewsFragment : BaseNewsFragment() {
             viewLifecycleOwner.lifecycleScope.launch {
                 val newsItem = n?.let { it1 ->
                     NewsItemMapper.map(
-                        it1, mRealm, mutableMapOf()
+                        it1, mutableMapOf()
                     )
                 }
                 val currentList = searchFilteredList.toMutableList()

app/src/main/java/org/ole/planet/myplanet/ui/news/NewsItemMapper.kt

@@ -15,13 +15,21 @@ import org.ole.planet.myplanet.utilities.JsonUtils
 object NewsItemMapper {
     private val gson = Gson()
 
-    suspend fun map(news: RealmNews, realm: Realm, userCache: MutableMap<String, RealmUserModel?>): NewsItem = withContext(Dispatchers.Default) {
+    suspend fun map(news: RealmNews, userCache: MutableMap<String, RealmUserModel?>): NewsItem = withContext(Dispatchers.Default) {
         val sharedTeamName = extractSharedTeamName(news.viewIn)
         val imageUrls = parseImageUrls(news.imageUrls)
         val resourceIds = parseImagesArray(news.imagesArray)
-        val libraryItems = getLibraryItems(resourceIds, realm)
         val conversations = parseConversations(news.conversations)
-        val user = getUser(news.userId, realm, userCache)
+
+        var detachedUser: RealmUserModel? = null
+        var detachedLibraryItems: List<RealmMyLibrary?> = emptyList()
+
+        Realm.getDefaultInstance().use { realm ->
+            val libraryItems = getLibraryItems(resourceIds, realm)
+            val user = getUser(news.userId, realm, userCache)
+            detachedUser = user?.let { if (it.isValid) realm.copyFromRealm(it) else null }
+            detachedLibraryItems = libraryItems.map { if (it.isValid) realm.copyFromRealm(it) else null }
+        }
 
         NewsItem(
             id = news.id ?: "",
@@ -42,8 +50,8 @@ object NewsItemMapper {
             viewableBy = news.viewableBy,
             viewableId = news.viewableId,
             sharedTeamName = sharedTeamName,
-            user = user?.let { if (it.isValid) realm.copyFromRealm(it) else null },
-            library = libraryItems.map { if (it.isValid) realm.copyFromRealm(it) else null }
+            user = detachedUser,
+            library = detachedLibraryItems
         )
     }
 

app/src/main/java/org/ole/planet/myplanet/ui/news/ReplyActivity.kt

@@ -88,10 +88,10 @@ open class ReplyActivity : AppCompatActivity(), OnNewsItemClickListener {
             val (news, list) = viewModel.getNewsWithReplies(id)
             val userCache = mutableMapOf<String, RealmUserModel?>()
             val parentNewsItem = news?.let {
-                NewsItemMapper.map(it, databaseService.realmInstance, userCache)
+                NewsItemMapper.map(it, userCache)
             }
             val newsItems = list.map {
-                NewsItemMapper.map(it, databaseService.realmInstance, userCache)
+                NewsItemMapper.map(it, userCache)
             }
             databaseService.withRealm { realm ->
                 newsAdapter = AdapterNews(

app/src/main/java/org/ole/planet/myplanet/ui/team/teamDiscussion/DiscussionListFragment.kt

@@ -130,6 +130,7 @@ class DiscussionListFragment : BaseTeamFragment() {
                 if (isAdded) {
                     filteredNewsList = newsItems
                     setData(filteredNewsList)
+                    updateNotificationCount(newsItems.size)
                 }
             }
         }
@@ -138,19 +139,7 @@ class DiscussionListFragment : BaseTeamFragment() {
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
-        val realmNewsList = news
-        val count = realmNewsList.size
-        mRealm.executeTransactionAsync { realm: Realm ->
-            var notification = realm.where(RealmTeamNotification::class.java).equalTo("type", "chat").equalTo("parentId", getEffectiveTeamId()).findFirst()
-            if (notification == null) {
-                notification = realm.createObject(RealmTeamNotification::class.java, UUID.randomUUID().toString())
-                notification.parentId = getEffectiveTeamId()
-                notification.type = "chat"
-            }
-            notification?.lastCount = count
-        }
         changeLayoutManager(resources.configuration.orientation, binding.rvDiscussion)
-        showRecyclerView(realmNewsList)
 
         viewLifecycleOwner.lifecycleScope.launch {
             viewLifecycleOwner.repeatOnLifecycle(Lifecycle.State.STARTED) {
@@ -206,7 +195,7 @@ class DiscussionListFragment : BaseTeamFragment() {
         }
 
         return filtered.map { news ->
-            NewsItemMapper.map(news, mRealm, userCache)
+            NewsItemMapper.map(news, userCache)
         }
     }
 
@@ -257,6 +246,20 @@ class DiscussionListFragment : BaseTeamFragment() {
         super.onDestroyView()
     }
 
+    private fun updateNotificationCount(count: Int) {
+        mRealm.executeTransactionAsync { realm: Realm ->
+            var notification = realm.where(RealmTeamNotification::class.java).equalTo("type", "chat")
+                .equalTo("parentId", getEffectiveTeamId()).findFirst()
+            if (notification == null) {
+                notification =
+                    realm.createObject(RealmTeamNotification::class.java, UUID.randomUUID().toString())
+                notification.parentId = getEffectiveTeamId()
+                notification.type = "chat"
+            }
+            notification?.lastCount = count
+        }
+    }
+
     private fun shouldQueryTeamFromRealm(): Boolean {
         val hasDirectData = requireArguments().containsKey("teamName") &&
                 requireArguments().containsKey("teamType") &&