teams: smoother list visit counts caching (fixes #8990) (#8952)

Author: dogi

app/build.gradle

@@ -9,8 +9,8 @@ android {
         applicationId "org.ole.planet.myplanet"
         minSdk = 26
         targetSdk = 36
-        versionCode = 3706
-        versionName = "0.37.6"
+        versionCode = 3707
+        versionName = "0.37.7"
         ndkVersion = '26.3.11579264'
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true

app/src/main/java/org/ole/planet/myplanet/ui/team/AdapterTeamList.kt

@@ -47,6 +47,7 @@ class AdapterTeamList(
     private var filteredList: List<RealmMyTeam> = emptyList()
     private lateinit var prefData: SharedPrefManager
     private val teamStatusCache = mutableMapOf<String, TeamStatus>()
+    private val visitCountsCache = mutableMapOf<String, Long>()
     private var visitCounts: Map<String, Long> = emptyMap()
     private var updateListJob: Job? = null
 
@@ -261,8 +262,13 @@ class AdapterTeamList(
             }
 
             val teamIds = validTeams.mapNotNull { it._id?.takeIf { id -> id.isNotBlank() } }
-            val visitCountsDeferred = async(Dispatchers.IO) {
-                teamRepository.getRecentVisitCounts(teamIds)
+            val (cachedVisitIds, nonCachedVisitIds) = teamIds.partition { it in visitCountsCache }
+            val visitCountsDeferred = if (nonCachedVisitIds.isNotEmpty()) {
+                async(Dispatchers.IO) {
+                    teamRepository.getRecentVisitCounts(nonCachedVisitIds)
+                }
+            } else {
+                async { emptyMap<String, Long>() }
             }
 
             val statusResults = mutableMapOf<String, TeamStatus>()
@@ -297,6 +303,8 @@ class AdapterTeamList(
             }
 
             val newVisitCounts = visitCountsDeferred.await()
+            newVisitCounts.forEach { (id, count) -> visitCountsCache[id] = count }
+            val allVisitCounts = cachedVisitIds.associateWith { visitCountsCache[it]!! } + newVisitCounts
             val sortedTeams = validTeams.sortedWith(
                 compareByDescending<RealmMyTeam> { team ->
                     val teamId = team._id.orEmpty()
@@ -307,7 +315,7 @@ class AdapterTeamList(
                         else -> 1
                     }
                 }.thenByDescending { team ->
-                    newVisitCounts[team._id.orEmpty()] ?: 0L
+                    allVisitCounts[team._id.orEmpty()] ?: 0L
                 }
             )
 
@@ -321,7 +329,7 @@ class AdapterTeamList(
                     createdDate = team.createdDate,
                     type = team.type,
                     status = team.status,
-                    visitCount = newVisitCounts[teamId] ?: 0L,
+                    visitCount = allVisitCounts[teamId] ?: 0L,
                     teamStatus = teamStatusCache[cacheKey]
                 )
             }
@@ -330,7 +338,7 @@ class AdapterTeamList(
                 DiffUtil.calculateDiff(TeamDiffCallback(oldList, newList))
             }
 
-            visitCounts = newVisitCounts
+            visitCounts = allVisitCounts
             filteredList = sortedTeams
             diffResult.dispatchUpdatesTo(this@AdapterTeamList)
             updateCompleteListener?.onUpdateComplete(filteredList.size)
@@ -409,6 +417,12 @@ class AdapterTeamList(
         this.type = type
     }
 
+    fun cleanup() {
+        scope.cancel()
+        teamStatusCache.clear()
+        visitCountsCache.clear()
+    }
+
     override fun getItemCount(): Int = filteredList.size
 
     class ViewHolderTeam(val binding: ItemTeamListBinding) : RecyclerView.ViewHolder(binding.root)