teams: smoother list callback diffing (fixes #9034) (#9013)

Author: dogi

app/build.gradle

@@ -9,8 +9,8 @@ android {
         applicationId "org.ole.planet.myplanet"
         minSdk = 26
         targetSdk = 36
-        versionCode = 3721
-        versionName = "0.37.21"
+        versionCode = 3722
+        versionName = "0.37.22"
         ndkVersion = '26.3.11579264'
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true

app/src/main/java/org/ole/planet/myplanet/ui/team/AdapterTeamList.kt

@@ -29,6 +29,7 @@ import org.ole.planet.myplanet.model.RealmUserModel
 import org.ole.planet.myplanet.repository.TeamRepository
 import org.ole.planet.myplanet.ui.feedback.FeedbackFragment
 import org.ole.planet.myplanet.ui.navigation.NavigationHelper
+import org.ole.planet.myplanet.utilities.DiffUtils
 import org.ole.planet.myplanet.utilities.SharedPrefManager
 import org.ole.planet.myplanet.utilities.TimeUtils
 
@@ -251,7 +252,12 @@ class AdapterTeamList(
 
             if (validTeams.isEmpty()) {
                 val diffResult = withContext(Dispatchers.Default) {
-                    DiffUtil.calculateDiff(TeamDiffCallback(oldList, emptyList()))
+                    DiffUtils.calculateDiff(
+                        oldList,
+                        emptyList(),
+                        areItemsTheSame = { old, new -> old._id == new._id },
+                        areContentsTheSame = { old, new -> old == new }
+                    )
                 }
                 visitCounts = emptyMap()
                 filteredList = emptyList()
@@ -334,7 +340,12 @@ class AdapterTeamList(
             }
 
             val diffResult = withContext(Dispatchers.Default) {
-                DiffUtil.calculateDiff(TeamDiffCallback(oldList, newList))
+                DiffUtils.calculateDiff(
+                    oldList,
+                    newList,
+                    areItemsTheSame = { old, new -> old._id == new._id },
+                    areContentsTheSame = { old, new -> old == new }
+                )
             }
 
             visitCounts = allVisitCounts
@@ -344,20 +355,6 @@ class AdapterTeamList(
         }
     }
 
-    private class TeamDiffCallback(
-        private val oldList: List<TeamData>, private val newList: List<TeamData>
-    ) : DiffUtil.Callback() {
-        override fun getOldListSize(): Int = oldList.size
-        override fun getNewListSize(): Int = newList.size
-        override fun areItemsTheSame(oldItemPosition: Int, newItemPosition: Int): Boolean {
-            return oldList[oldItemPosition]._id == newList[newItemPosition]._id
-        }
-
-        override fun areContentsTheSame(oldItemPosition: Int, newItemPosition: Int): Boolean {
-            return oldList[oldItemPosition] == newList[newItemPosition]
-        }
-    }
-
     private fun requestToJoin(team: RealmMyTeam, user: RealmUserModel?) {
         val teamId = team._id ?: return
         val teamType = team.teamType