Skip to content

Content Reduction: Remove redundant mentions of the two-approver PR merge requirement #3698

@uj-sxn

Description

@uj-sxn

Please verify the following:

URL to the MDwiki page containing the problem

https://open-learning-exchange.github.io/#!./pages/vi/vi-create-issues-and-pull-requests.md

Problem

Location of Problem:
The approval requirement is stated repeatedly in Step 8 - Create More Issues and Pull Requests (vi-create-issues-and-pull-requests.md).

Problem Details (Repetitive Content):
The requirement that Pull Requests (PRs) must be approved by "at least two other OLE team members/interns" is mentioned multiple times.

  1. Introduction Section: States PRs must be approved by two members.
  2. Section 3 (Resolve Issues): States PRs must be approved by two members.

Screenshots (when necessary)

Location where correction is needed:

  1. Image
  2. Image

Proposed solution(s)

Proposed Solution (Content Reduction):

  • Remove the repetitive mention of the approval requirement from the Introduction section (Source 604).

  • The requirement should only be stated once, and the most logical place is under "3. Resolve Issues with Pull Requests", as that is the section dealing specifically with the PR resolution and merging process.

Metadata

Metadata

Assignees

No one assigned

    Labels

    vifirst steps - software engineering virtual intern

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions