manager: smoother surveys error handling (fixes #9194) (#9197)

Co-authored-by: dogi <[email protected]>

Author: Mutugiii

package.json

@@ -1,10 +1,10 @@
 {
   "name": "planet",
   "license": "AGPL-3.0",
-  "version": "0.20.47",
+  "version": "0.20.48",
   "myplanet": {
-    "latest": "v0.34.30",
-    "min": "v0.33.30"
+    "latest": "v0.34.32",
+    "min": "v0.33.32"
   },
   "scripts": {
     "ng": "ng",

src/app/submissions/submissions.component.html

@@ -71,7 +71,8 @@
       <ng-container matColumnDef="teamInfo">
         <mat-header-cell *matHeaderCellDef mat-sort-header="teamInfo" i18n>Team/Enterprise</mat-header-cell>
         <mat-cell *matCellDef="let element" style="cursor: pointer">
-          <ng-container *ngIf="element.teamInfo">{{element.teamInfo?.name}} ({{getTeamTypeLabel(element.teamInfo?.type)}})</ng-container>
+          <ng-container *ngIf="element.teamInfo && !element.teamInfo.missing">{{element.teamInfo?.name}} ({{getTeamTypeLabel(element.teamInfo?.type)}})</ng-container>
+          <ng-container *ngIf="element.teamInfo?.missing"><i i18n>(missing)</i></ng-container>
         </mat-cell>
       </ng-container>
       <ng-container matColumnDef="status">

src/app/submissions/submissions.service.ts

@@ -330,7 +330,7 @@ export class SubmissionsService {
   }
 
   getAnswerText(answers: any[], index, answerIndexes: number[]) {
-    const answer = answerIndexes[index] > -1 ? answers[index].value : undefined;
+    const answer = answerIndexes[index] > -1 && answers[index] ? answers[index].value : undefined;
     return answer && (
       Array.isArray(answer) ? answer.reduce((ans, v) => ans + v.text + ',', '').slice(0, -1) : answer.text || answer
     );

src/app/teams/teams.service.ts

@@ -1,6 +1,6 @@
 import { Injectable } from '@angular/core';
 import { of, empty, forkJoin, Observable } from 'rxjs';
-import { switchMap, map, take } from 'rxjs/operators';
+import { switchMap, map, take, catchError } from 'rxjs/operators';
 import { CouchService } from '../shared/couchdb.service';
 import { UserService } from '../shared/user.service';
 import { DialogsFormService } from '../shared/dialogs/dialogs-form.service';
@@ -388,6 +388,7 @@ export class TeamsService {
         }
         return { id: teamId };
       }),
+      catchError(() => of({ id: teamId, missing: true }))
     );
   }