Skip to content

Commit 5a394b8

Browse files
authored
ci(golangci-lint): Disable revive skip-package-name-collision-with-go-std (#1232)
This is blocking PRs due to conflict over package names like 'xml' and 'json' but those names make sense in conftest's context. Signed-off-by: James Alseth <[email protected]>
1 parent 10434c1 commit 5a394b8

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

.golangci.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,16 @@ linters:
2323
- nilness
2424
misspell:
2525
locale: US
26+
revive:
27+
rules:
28+
- name: var-naming
29+
# Arguments accepts an allow list, a deny list, and a map of other options.
30+
# https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#var-naming
31+
arguments:
32+
- [] # Allow list. Do not remove because ordering matters.
33+
- [] # Deny list. Do not remove because ordering matters.
34+
-
35+
- skip-package-name-collision-with-go-std: true
2636
staticcheck:
2737
checks:
2838
# These are processed in order. It is important that the inclusion

scripts/validate-conventional-commit-prefix.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set -eo pipefail
44

55
code=0
66
while read -r commit; do
7-
match=$(echo "${commit}" | grep -o -h -E "^[a-z]+(\([a-z]+\))?: " || true)
7+
match=$(echo "${commit}" | grep -o -h -E "^[a-z]+(\([a-z-]+\))?: " || true)
88
if [[ -z "${match}" ]]; then
99
echo "::error::Commit \"${commit}\" does not have the required conventional commit prefix. See https://www.conventionalcommits.org/ for more info."
1010
code=1

0 commit comments

Comments
 (0)