-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage support to verify command #518
Comments
Not opposed to the idea of returning a non-zero error code based on coverage, but would lean more towards something along the lines of:
Where 80 represents the minimum percentage NOTE: OPA binary exposes |
@jpreese I did write in my first post that the When do you think this feature could be added to |
Yep! I saw it, just leaving a note that they split coverage and threshold into two different flags, rather than just a single one. At the moment, I don't have a timeline just whenever someone opens a pull request 😄 |
Thanks @jpreese. Not a big deal, for now i'm using the opa binary for unit tests + coverage check. |
Opa doesn't have the parse_config or parse_config_file functions so I can't do coverage when I use thoses. |
Hi,
The
opa test
command has a--coverage
flag which outputs the tests coverage.Can this be added to
conftest verify
?It would be great if it would be possible to make it exit with exit code 1 if coverage is not 100.
Thanks
The text was updated successfully, but these errors were encountered: