Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OQS_*_set_callbacks instead of C_OR_NI_OR_ARM macros #1842

Open
SWilson4 opened this issue Jul 12, 2024 · 0 comments
Open

Use OQS_*_set_callbacks instead of C_OR_NI_OR_ARM macros #1842

SWilson4 opened this issue Jul 12, 2024 · 0 comments
Labels
good first issue Issue for new contributors refactor Reorganizing existing code

Comments

@SWilson4
Copy link
Member

          This isn't something to change in this PR, but something I noticed just from looking at this code during review.  Now that we have the ability to set callbacks, could we get rid of the `C_OR_NI_OR_ARM` macros and instead set the callbacks once (either during library init, or alternatively on first use if it's not set)?  Again: not something to do in this PR, but if anyone else thinks it might be good, we could create a separate issue to track.

Originally posted by @dstebila in #1707 (comment)

See also: #1599, #1832

@SWilson4 SWilson4 added refactor Reorganizing existing code good first issue Issue for new contributors labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue for new contributors refactor Reorganizing existing code
Projects
Status: Todo
Development

No branches or pull requests

1 participant