Merge pull request #5 from open-rpc/fix/remove-emoji

fix: remove emoji from console reporter

Author: shanejonas

bin/cli.js

@@ -3,7 +3,6 @@ const program = require('commander');
 const orpcCoverage = require('../build').default;
 const { parseOpenRPCDocument } = require('@open-rpc/schema-utils-js');
 
-
 const getSkipMethods = (input) => {
   if (input && input.split(',').length > 0) {
     return input.split(',');
@@ -18,7 +17,7 @@ program
   .option('-s, --schema [schema]', 'JSON string or a Path/Url pointing to an open rpc schema')
   .option('-r, --reporter <reporter>', 'Use the specified reporter [console] [json]')
   .option('-t, --transport <transport>', 'Use the specified transport [http]')
-  .option('--skipMethods <skipMethods>', 'Use the specified transport [http]')
+  .option('--skipMethods <skipMethods>', 'Methods to skip')
   .action(async () => {
     let schema;
     try {

package-lock.json

@@ -20,8 +20,9 @@
     "@open-rpc/meta-schema": "^1.3.1",
     "@open-rpc/schema-utils-js": "^1.6.3",
     "@types/isomorphic-fetch": "0.0.35",
-    "json-schema-faker": "^0.5.0-rc16",
+    "colors": "^1.3.3",
     "isomorphic-fetch": "^2.2.1",
+    "json-schema-faker": "^0.5.0-rc16",
     "json-schema-ref-parser": "^6.1.0"
   },
   "devDependencies": {

package.json

@@ -9,7 +9,6 @@ const getParams = async (params: any[]) => {
   return Promise.all(promises);
 }
 
-const results: any[] = [];
 
 interface IOptions {
   schema: OpenRPC;
@@ -19,9 +18,10 @@ interface IOptions {
 }
 
 export default async (options: IOptions) => {
+  const results: any[] = [];
   const promises = options.schema.methods.map(async (method) => {
     if (options.skipMethods.includes(method.name)) {
-      return Promise.resolve();
+      return;
     }
     const params = await getParams(method.params);
     const urls = (options.schema.servers || []).map((u) => {
@@ -31,27 +31,16 @@ export default async (options: IOptions) => {
     return Promise.all(urls.map((url) => {
       return options.transport(url, method.name, params)
         .then((r: any) => {
-          if (r.error && r.error.message.includes('does not exist')) {
-            results.push({
-              method: method.name,
-              error: 'Method Does Not Exist'
-            });
-          } else if (r.error) {
-            results.push({
-              method: method.name,
-              error: r.error.message
-            });
-          } else {
-            results.push({
-              method: method.name,
-              result: r.result
-            });
-          }
+          results.push({
+            method: method.name,
+            params,
+            ...r
+          })
         });
     }))
   });
 
   return Promise.all(promises).then(() => {
     return results;
   }).then(options.reporter)
-}
+}

src/coverage.ts

@@ -22,9 +22,9 @@ interface IOptions {
 
 export default async (options: IOptions) => {
   return coverage({
-    reporter: reporters[options.reporter],
+    reporter: reporters[options.reporter || 'console'],
     schema: options.schema,
     skipMethods: options.skipMethods || [],
-    transport: transports[options.transport]
+    transport: transports[options.transport || 'http']
   });
 }

src/index.ts

@@ -1,3 +1,5 @@
+import colors from 'colors';
+
 export default (callResults: any[]) => {
   const metrics = {
     errors: 0,
@@ -6,14 +8,16 @@ export default (callResults: any[]) => {
   callResults.forEach((call) => {
     if (call.error) {
       metrics.errors++;
-      console.log('⛔️', call.method, 'ERROR:', call.error)
+      console.log(colors.red.underline('Error: '), colors.cyan(call.method));
+      console.log(call.error);
+      console.log(call.params);
     } else {
       metrics.success++;
-      console.log('✅', call.method)
+      console.log(colors.green('Success: '), call.method)
     }
   })
   console.log('==========');
-  console.log('Success: ', metrics.success);
-  console.log('Errors: ', metrics.errors);
+  console.log('Success: ', colors.green(metrics.success.toString()));
+  console.log('Errors: ', colors.red(metrics.errors.toString()));
   console.log('==========');
-};
+};