Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: display changes when summary is created #191

Open
2 tasks done
BekahHW opened this issue Jun 20, 2023 · 6 comments
Open
2 tasks done

Bug: display changes when summary is created #191

BekahHW opened this issue Jun 20, 2023 · 6 comments
Labels
🐛 bug Something isn't working

Comments

@BekahHW
Copy link
Member

BekahHW commented Jun 20, 2023

Describe the bug

When you create a highlight and use the summarize feature, the panel shrinks. It would be nice if the size stayed consistent.

highlight summary

Steps to reproduce

  1. Go to a PR
  2. Open the chrome ext in the browser
  3. Click Post Highlight
  4. See the panel shrink

Browsers

Chrome

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@BekahHW BekahHW added the 🐛 bug Something isn't working label Jun 20, 2023
@bdougie bdougie added this to the Extension Features milestone Jun 27, 2023
@diivi diivi self-assigned this Jun 29, 2023
@bdougie bdougie moved this from Todo to In Progress in Extension Status Board Jul 1, 2023
@diivi
Copy link
Contributor

diivi commented Jul 15, 2023

Do you have a solution in mind? I thought of increasing the input box's height but that'll make it too long. Also, I won't know what height to set because of changes to the extension's homepage.

@takanome-dev
Copy link

How about making the textarea auto-resizable like open-sauced/app#1137

@diivi
Copy link
Contributor

diivi commented Jul 16, 2023

That doesn't really seem like a solution to the problem mentioned in the issues though. The window will still change sizes.

@BekahHW
Copy link
Member Author

BekahHW commented Jul 28, 2023

I'm not really sure what the solution would be. I'd be inclined to have it stay the same size all the time and if the highlight is long have a scroll or read more option. But that doesn't sound great either.

@diivi diivi removed their assignment Aug 3, 2023
@a0m0rajab
Copy link
Contributor

I thought about such a design but it felt a bit too bulky:

Old:
image

New:
image

@nickytonline
Copy link
Member

We can probably set a min-height on the body in the popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
Status: In Progress
Development

No branches or pull requests

6 participants