Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: package files glob pattern matches dependency package files #20

Closed
2 tasks done
Anush008 opened this issue Aug 21, 2023 · 1 comment · Fixed by #21
Closed
2 tasks done

Bug: package files glob pattern matches dependency package files #20

Anush008 opened this issue Aug 21, 2023 · 1 comment · Fixed by #21
Labels
🐛 bug Something isn't working released

Comments

@Anush008
Copy link
Member

Anush008 commented Aug 21, 2023

Describe the bug

#19 introduced a regression in the glob patterns

release/release.config.js

Lines 167 to 187 in f0f6357

addPlugin("@semantic-release/git", {
"assets": [
"LICENSE*",
"CHANGELOG.md",
"package.json",
"package-lock.json",
"npm-shrinkwrap.json",
"yarn.lock",
"pnpm-lock.yaml",
"**/package.json",
"**/package-lock.json",
"**/npm-shrinkwrap.json",
"**/yarn.lock",
"**/pnpm-lock.yaml",
"public/**/*",
"supabase/**/*",
"action.yml",
"manifest.json"
],
"message": `chore(<%= nextRelease.type %>): release <%= nextRelease.version %> <%= nextRelease.channel !== null ? \`on \${nextRelease.channel} channel \` : '' %>[skip ci]\n\n<%= nextRelease.notes %>`
});

These patterns also match the package files of dependencies within node_modules.

Steps to reproduce

The repo currently has a node_modules dir with package files.

Browsers

No response

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@Anush008 Anush008 added the 🐛 bug Something isn't working label Aug 21, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant