S3 exporter: endpoint documentation / bucket

[dabcoder]

The S3 exporter documentation states that the endpoint parameter overrides the endpoint used by the exporter instead of constructing it from region and s3_bucket .

Yet in the code there is:

if c.S3Uploader.S3Bucket == "" {
  errs = multierr.Append(errs, errors.New("bucket is required"))
}

However, when the endpoint is provided, it should also contain the S3 bucket, thus I would not expect the s3_bucket to have to be provided and this error to be returned. Am I misunderstanding the config setup here?

[dmitryax]

Seems like a bug in validation. @dabcoder feel free to submit a PR. cc @atoulme @pdelewski as code owners

[dmitryax]

Converted into an issue #32774

[dabcoder]

Thanks for the prompt response. Yes I will see if I can tackle it and will let you know how it goes.

[dabcoder]

Closing this as this can be tracked in the above issue (and linked PR)