Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout config key collision #37332

Open
vigr opened this issue Jan 20, 2025 · 1 comment
Open

Timeout config key collision #37332

vigr opened this issue Jan 20, 2025 · 1 comment
Labels
bug Something isn't working exporter/prometheusremotewrite needs triage New item requiring triage

Comments

@vigr
Copy link

vigr commented Jan 20, 2025

Component(s)

exporter/prometheusremotewrite

What happened?

Description

There is a collision of config keys here:

  • exporter/prometheusremotewriteexporter - Timeout for whole operation of PushMetrics collides with Timeout of HTTP requests to Victoria Metrics. The collision makes it impossible to configure different timeouts for whole operation vs each request thus preventing retries in case of timeouts.

Steps to Reproduce

Try to configure both Config.Timout and Config.ClientConfig.Timeout.

Expected Result

The timeouts are different.

Actual Result

The timeouts are equal and have the value given by "timeout" key in config file.

Collector version

v0.117.0,v0.111.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

Log output

Additional context

No response

@vigr vigr added bug Something isn't working needs triage New item requiring triage labels Jan 20, 2025
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter/prometheusremotewrite needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

1 participant