Recombine transformer ignores skip logic

[RoryCrispin]

Component(s)

pkg/stanza

What happened?

Description

The Recombine transformer does not respect Skip logic, for example:

        - type: recombine
          is_first_entry: body matches "^(\\s*\\d{4}[.]\\d{2}[.]\\d{2}|{.date)"
          combine_field: body
          combine_with: "\n"
          source_identifier: attributes["log.file.path"]
          if: resource.app matches "^clickhouse-"

should only apply when the 'if' condition returns truthy, however in practice it executes for every log line.

The following patch was added to our fork to re-implement the correct logic;
ClickHouse@a080642

Steps to Reproduce

Create a simple recombine transformer with an if gate

Expected Result

The transformer should only operate when the if evaluates truthily

Actual Result

The transformer always operates

Collector version

v0.118.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

Log output

Additional context

No response

[github-actions]

Pinging code owners:

• pkg/stanza: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.