[processor/resourcedetection] Use compute.osProfile.computerName instead of VM Name for setting host.name in Azure
#43969
+41
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… VM Name for setting `host.name` in Azure Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
github-actions
bot
added
processor/resourcedetection
Member
Author
|
/label waiting-for-code-owners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the value being set for the
host.nameresource attribute in Azure environments using Virtual Machine Scale Sets (VMSS).Previously, the
compute.namefield was being used for bothhost.nameandazure.vm.name. While this value is equal for traditional Azure VMs, for VMSS, it seems more accurate to use the value ofcompute.osProfile.computerName.To address this, the processor now retrieves the
host.namevalue from the Instance Metadata Service (IMDS) fieldcompute.osProfile.computerName.Link to tracking issue
Fixes #43959
Testing
Updated tests accordingly.