Upgrade OTLP to 1.9.0 (#14128)

Upgrade OTLP to 1.9.0.
See
https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v1.9.0

Contrib tests are fixed in
open-telemetry/opentelemetry-collector-contrib#44031

Author: dmathieu

.chloggen/otlp-1-9-0.yaml

@@ -0,0 +1,25 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+
+# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
+component: pkg/pdata
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Upgrade the OTLP protobuf definitions to version 1.9.0
+
+# One or more tracking issues or pull requests related to the change
+issues: [14128]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [api]

.chloggen/profiles-otlp-1-9-0.yaml

@@ -0,0 +1,32 @@
+# cspell:ignore Strindices
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: breaking
+
+# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
+component: pdata/pprofile
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Upgrade the OTLP protobuf definitions to version 1.9.0
+
+# One or more tracking issues or pull requests related to the change
+issues: [14128]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext: |
+  * Drop field `CommentStrindices` in `Profile`.
+  * Rename `Sample` to `Samples` in `Profile`.
+  * Rename `Line` to `Lines` in `Location`.
+  * Remove `AggregationTemporality` field in `ValueType`.
+
+  See https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v1.9.0
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [api]

exporter/debugexporter/internal/normal/profiles.go

@@ -42,7 +42,7 @@ func (normalProfilesMarshaler) MarshalProfiles(pd pprofile.Profiles) ([]byte, er
 				buffer.WriteString(profile.ProfileID().String())
 
 				buffer.WriteString(" samples=")
-				buffer.WriteString(strconv.Itoa(profile.Sample().Len()))
+				buffer.WriteString(strconv.Itoa(profile.Samples().Len()))
 
 				if profile.AttributeIndices().Len() > 0 {
 					attrs := []string{}

exporter/debugexporter/internal/normal/profiles_test.go

@@ -43,8 +43,8 @@ func TestMarshalProfiles(t *testing.T) {
 				profiles.ResourceProfiles().At(0).ScopeProfiles().At(0).Scope().SetVersion("1.2.3")
 				profiles.ResourceProfiles().At(0).ScopeProfiles().At(0).Scope().Attributes().PutStr("scopeKey", "scopeValue")
 				profile.SetProfileID([16]byte{0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F, 0x10})
-				profile.Sample().AppendEmpty()
-				profile.Sample().AppendEmpty()
+				profile.Samples().AppendEmpty()
+				profile.Samples().AppendEmpty()
 				profile.AttributeIndices().Append(0)
 				return profiles
 			}(),

exporter/debugexporter/internal/otlptext/databuffer.go

@@ -384,10 +384,10 @@ func (b *dataBuffer) logProfileLocations(ls pprofile.LocationSlice) {
 
 		b.logEntry("    Mapping index: %d", location.MappingIndex())
 		b.logEntry("    Address: %d", location.Address())
-		if ll := location.Line().Len(); ll > 0 {
+		if ll := location.Lines().Len(); ll > 0 {
 			for j := range ll {
 				b.logEntry("    Line #%d", j)
-				line := location.Line().At(j)
+				line := location.Lines().At(j)
 				b.logEntry("        Function index: %d", line.FunctionIndex())
 				b.logEntry("        Line: %d", line.Line())
 				b.logEntry("        Column: %d", line.Column())
@@ -424,17 +424,6 @@ func (b *dataBuffer) logStringTable(ss pcommon.StringSlice) {
 	}
 }
 
-func (b *dataBuffer) logComment(c pcommon.Int32Slice) {
-	if c.Len() == 0 {
-		return
-	}
-
-	b.logEntry("    Comment:")
-	for i := 0; i < c.Len(); i++ {
-		b.logEntry("        %d", c.At(i))
-	}
-}
-
 func keyValueAndUnitsToMap(aus pprofile.KeyValueAndUnitSlice) pcommon.Map {
 	m := pcommon.NewMap()
 	for i := 0; i < aus.Len(); i++ {

exporter/debugexporter/internal/otlptext/profiles.go

@@ -58,8 +58,7 @@ func (textProfilesMarshaler) MarshalProfiles(pd pprofile.Profiles) ([]byte, erro
 				buf.logAttr("Duration", profile.Duration().String())
 				buf.logAttr("Dropped attributes count", strconv.FormatUint(uint64(profile.DroppedAttributesCount()), 10))
 
-				buf.logProfileSamples(profile.Sample(), dic)
-				buf.logComment(profile.CommentStrindices())
+				buf.logProfileSamples(profile.Samples(), dic)
 			}
 		}
 	}

exporter/debugexporter/internal/otlptext/profiles_test.go

@@ -56,7 +56,7 @@ func extendProfiles(profiles pprofile.Profiles) pprofile.Profiles {
 	location := dic.LocationTable().AppendEmpty()
 	location.SetMappingIndex(3)
 	location.SetAddress(4)
-	line := location.Line().AppendEmpty()
+	line := location.Lines().AppendEmpty()
 	line.SetFunctionIndex(1)
 	line.SetLine(2)
 	line.SetColumn(3)
@@ -89,13 +89,9 @@ func extendProfiles(profiles pprofile.Profiles) pprofile.Profiles {
 	sc := profiles.ResourceProfiles().At(0).ScopeProfiles().At(0)
 	profilesCount := profiles.ResourceProfiles().At(0).ScopeProfiles().At(0).Profiles().Len()
 	for i := range profilesCount {
-		switch i % 2 {
-		case 0:
+		if i%2 == 0 {
 			profile := sc.Profiles().At(i)
 			profile.AttributeIndices().FromRaw([]int32{1})
-		case 1:
-			profile := sc.Profiles().At(i)
-			profile.CommentStrindices().FromRaw([]int32{1, 2})
 		}
 	}
 	return profiles
@@ -111,7 +107,7 @@ func generateProfilesWithEntityRefs() pprofile.Profiles {
 	sp.Scope().SetName("test-scope")
 	profile := sp.Profiles().AppendEmpty()
 
-	sample := profile.Sample().AppendEmpty()
+	sample := profile.Samples().AppendEmpty()
 	sample.Values().Append(100)
 
 	dic := pd.Dictionary()

exporter/debugexporter/internal/otlptext/testdata/profiles/two_profiles.out

@@ -62,6 +62,3 @@ Profile #1
         Values: [9]
         Attributes:
              -> key: value
-    Comment:
-        1
-        2

internal/cmd/pdatagen/internal/pdata/pprofile_package.go

@@ -244,7 +244,7 @@ var profile = &messageStruct{
 			returnMessage: valueType,
 		},
 		&SliceField{
-			fieldName:   "Sample",
+			fieldName:   "Samples",
 			protoID:     2,
 			protoType:   proto.TypeMessage,
 			returnSlice: sampleSlice,
@@ -277,16 +277,10 @@ var profile = &messageStruct{
 			protoID:   6,
 			protoType: proto.TypeInt64,
 		},
-		&SliceField{
-			fieldName:   "CommentStrindices",
-			protoID:     7,
-			protoType:   proto.TypeInt32,
-			returnSlice: int32Slice,
-		},
 		&TypedField{
 			fieldName:       "ProfileID",
 			originFieldName: "ProfileId",
-			protoID:         8,
+			protoID:         7,
 			returnType: &TypedType{
 				structName:  "ProfileID",
 				protoType:   proto.TypeMessage,
@@ -297,23 +291,23 @@ var profile = &messageStruct{
 		},
 		&PrimitiveField{
 			fieldName: "DroppedAttributesCount",
-			protoID:   9,
+			protoID:   8,
 			protoType: proto.TypeUint32,
 		},
 		&PrimitiveField{
 			fieldName: "OriginalPayloadFormat",
-			protoID:   10,
+			protoID:   9,
 			protoType: proto.TypeString,
 		},
 		&SliceField{
 			fieldName:   "OriginalPayload",
-			protoID:     11,
+			protoID:     10,
 			protoType:   proto.TypeBytes,
 			returnSlice: byteSlice,
 		},
 		&SliceField{
 			fieldName:   "AttributeIndices",
-			protoID:     12,
+			protoID:     11,
 			protoType:   proto.TypeInt32,
 			returnSlice: int32Slice,
 		},
@@ -387,7 +381,7 @@ var valueTypeSlice = &messageSlice{
 
 var valueType = &messageStruct{
 	structName:    "ValueType",
-	description:   "// ValueType describes the type and units of a value, with an optional aggregation temporality.",
+	description:   "// ValueType describes the type and units of a value.",
 	protoName:     "ValueType",
 	upstreamProto: "gootlpprofiles.ValueType",
 	fields: []Field{
@@ -401,17 +395,6 @@ var valueType = &messageStruct{
 			protoID:   2,
 			protoType: proto.TypeInt32,
 		},
-		&TypedField{
-			fieldName: "AggregationTemporality",
-			protoID:   3,
-			returnType: &TypedType{
-				structName:  "AggregationTemporality",
-				protoType:   proto.TypeEnum,
-				messageName: "AggregationTemporality",
-				defaultVal:  "AggregationTemporality(0)",
-				testVal:     "AggregationTemporality(1)",
-			},
-		},
 	},
 }
 
@@ -522,7 +505,7 @@ var location = &messageStruct{
 			protoType: proto.TypeUint64,
 		},
 		&SliceField{
-			fieldName:   "Line",
+			fieldName:   "Lines",
 			protoID:     3,
 			protoType:   proto.TypeMessage,
 			returnSlice: lineSlice,