Skip to content

Commit baef604

Browse files
committed
[receiverhelper] remove unnecessary level
The MeterProvider used to generate the matric will make calls to recording the metric Noops. Removing the level check. Signed-off-by: Alex Boten <[email protected]>
1 parent dadc331 commit baef604

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

receiver/receiverhelper/obsreport.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,13 @@ import (
1414
"go.opentelemetry.io/otel/trace"
1515

1616
"go.opentelemetry.io/collector/component"
17-
"go.opentelemetry.io/collector/config/configtelemetry"
1817
"go.opentelemetry.io/collector/internal/obsreportconfig/obsmetrics"
1918
"go.opentelemetry.io/collector/receiver"
2019
"go.opentelemetry.io/collector/receiver/receiverhelper/internal/metadata"
2120
)
2221

2322
// ObsReport is a helper to add observability to a receiver.
2423
type ObsReport struct {
25-
level configtelemetry.Level
2624
spanNamePrefix string
2725
transport string
2826
longLivedCtx bool
@@ -56,7 +54,6 @@ func newReceiver(cfg ObsReportSettings) (*ObsReport, error) {
5654
return nil, err
5755
}
5856
return &ObsReport{
59-
level: cfg.ReceiverCreateSettings.TelemetrySettings.MetricsLevel,
6057
spanNamePrefix: obsmetrics.ReceiverPrefix + cfg.ReceiverID.String(),
6158
transport: cfg.Transport,
6259
longLivedCtx: cfg.LongLivedCtx,
@@ -166,9 +163,7 @@ func (rec *ObsReport) endOp(
166163

167164
span := trace.SpanFromContext(receiverCtx)
168165

169-
if rec.level != configtelemetry.LevelNone {
170-
rec.recordMetrics(receiverCtx, dataType, numAccepted, numRefused)
171-
}
166+
rec.recordMetrics(receiverCtx, dataType, numAccepted, numRefused)
172167

173168
// end span according to errors
174169
if span.IsRecording() {

0 commit comments

Comments
 (0)