Skip to content

Commit e1bb99a

Browse files
authored
[confmap] Mark module as stable (#10920)
Fixes #9379. I removed two TODOs because I think we can just stay with the current behavior, but would want confirmation from @codeboten about this since it's mentioned here #4880 (review)
1 parent e375da4 commit e1bb99a

File tree

3 files changed

+26
-3
lines changed

3 files changed

+26
-3
lines changed

.chloggen/mx-psi_confmap-1.0.yaml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: enhancement
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
7+
component: confmap
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Mark module as stable
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [9379]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: []

confmap/confmap_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ func TestExpandNilStructPointersHookFunc(t *testing.T) {
114114
// assert.False(t, *cfg.Boolean)
115115
assert.Nil(t, cfg.Struct)
116116
assert.NotNil(t, cfg.MapStruct)
117-
// TODO: Investigate this unexpected result.
118117
assert.Equal(t, &Struct{}, cfg.MapStruct["struct"])
119118
}
120119

@@ -141,7 +140,6 @@ func TestExpandNilStructPointersHookFuncDefaultNotNilConfigNil(t *testing.T) {
141140
assert.NotNil(t, cfg.Struct)
142141
assert.Equal(t, s1, cfg.Struct)
143142
assert.NotNil(t, cfg.MapStruct)
144-
// TODO: Investigate this unexpected result.
145143
assert.Equal(t, &Struct{}, cfg.MapStruct["struct"])
146144
}
147145

versions.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ module-sets:
88
- go.opentelemetry.io/collector/client
99
- go.opentelemetry.io/collector/featuregate
1010
- go.opentelemetry.io/collector/pdata
11+
- go.opentelemetry.io/collector/confmap
1112
- go.opentelemetry.io/collector/config/configopaque
1213
- go.opentelemetry.io/collector/config/configcompression
1314
- go.opentelemetry.io/collector/config/configretry
@@ -22,7 +23,6 @@ module-sets:
2223
- go.opentelemetry.io/collector/component
2324
- go.opentelemetry.io/collector/component/componentstatus
2425
- go.opentelemetry.io/collector/component/componentprofiles
25-
- go.opentelemetry.io/collector/confmap
2626
- go.opentelemetry.io/collector/confmap/converter/expandconverter
2727
- go.opentelemetry.io/collector/confmap/provider/envprovider
2828
- go.opentelemetry.io/collector/confmap/provider/fileprovider

0 commit comments

Comments
 (0)