[chore]: enable-all rules from go-critic #13433
Open
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
gocritic/enable-all
branch
8 times, most recently
from
e51f525 to
ed482a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13433 +/- ##
==========================================
- Coverage 91.48% 91.47% -0.02%
==========================================
Files 529 529
Lines 29508 29508
==========================================
- Hits 26996 26992 -4
- Misses 1985 1988 +3
- Partials 527 528 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mmorel-35
force-pushed
the
gocritic/enable-all
branch
from
ed482a3 to
f747c33
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
gocritic/enable-all
branch
from
f747c33 to
a5fb556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables all rules from go-critic by default and disable the one that needs to be fixed