Replies: 1 comment
-
@alangy98 Yes indeed, any such change to reduce memory usage would be welcome, as long as any such global structure won't bring further mutex locks in the hot path of instrumentation. ps. There are also few places of heap allocations which can be optimized, but that could be different topic :) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello,
We are currently working on reducing the redundant storage of
MetricAttribute
. In the current implementation, the entireMetricAttributes
is stored in anunordered_map
. Labels with lower cardinality are stored multiple times alongside labels with higher cardinality. Additionally, attributes cannot be shared across different metrics, even though using the same or similarMetricAttributeSet
to update multiple metrics is common in real-world scenarios.Our preliminary work is to adopt the idea of
HPACK
, using a global table to minimize redundant storage of label keys and values. Would the community be receptive to these changes?Beta Was this translation helpful? Give feedback.
All reactions