Skip to content

[Infra] Ignore major/minor Docker updates #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

martincostello
Copy link
Member

#6321 (comment)

Changes

Only update to patch releases when updating Dockerfiles.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Only update to patch releases.
@Copilot Copilot AI review requested due to automatic review settings June 12, 2025 07:41
@martincostello martincostello requested a review from a team as a code owner June 12, 2025 07:41
@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Jun 12, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Dependabot configuration to only pull patch-level Docker image updates by ignoring major and minor version bumps.

  • Added ignore rules under each Docker update block.
  • Scoped ignore rules to three specific directories containing Dockerfiles.
Comments suppressed due to low confidence (3)

.github/dependabot.yml:16

  • The ignore: block is indented too far left compared to its sibling keys (directory, schedule, labels). It should be indented to the same level as labels: (two spaces under the list item) so Dependabot can parse it correctly.
ignore:

.github/dependabot.yml:40

  • This ignore: block under the second Docker section also has misaligned indentation. Align it to the same level as labels: to ensure the YAML is valid.
ignore:

.github/dependabot.yml:52

  • The ignore: entry in the third Docker update block is similarly indented incorrectly. It needs to match the indentation of its sibling keys for proper parsing.
ignore:

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (3f86f47) to head (996897a).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6326      +/-   ##
==========================================
- Coverage   86.76%   86.74%   -0.03%     
==========================================
  Files         258      258              
  Lines       11879    11879              
==========================================
- Hits        10307    10304       -3     
- Misses       1572     1575       +3     
Flag Coverage Δ
unittests-Project-Experimental 86.64% <ø> (+0.32%) ⬆️
unittests-Project-Stable 86.51% <ø> (-0.16%) ⬇️
unittests-Solution 86.66% <ø> (+0.22%) ⬆️
unittests-UnstableCoreLibraries-Experimental 85.87% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving/merging. I'm not a dependabot expert, so it's not clear to me if or how this will solve the issue, but I see it as a low risk to give it a shot.

@martincostello In the event this PR does not do what's intended maybe it makes sense to remove the weekly schedule temporarily. That might allow you to more quickly iterate on potential solutions. I'd be happy to merge things and give dependabot a kick to see what happens.

@alanwest alanwest merged commit 78a71eb into open-telemetry:main Jun 17, 2025
49 checks passed
@martincostello
Copy link
Member Author

Looks like it part-worked.

It's bumped the 8.0.x images to the latest patch, but it's not touched the 9.0.x ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants