-
Notifications
You must be signed in to change notification settings - Fork 831
[Infra] Ignore major/minor Docker updates #6326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Only update to patch releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Dependabot configuration to only pull patch-level Docker image updates by ignoring major and minor version bumps.
- Added
ignore
rules under each Docker update block. - Scoped ignore rules to three specific directories containing Dockerfiles.
Comments suppressed due to low confidence (3)
.github/dependabot.yml:16
- The
ignore:
block is indented too far left compared to its sibling keys (directory
,schedule
,labels
). It should be indented to the same level aslabels:
(two spaces under the list item) so Dependabot can parse it correctly.
ignore:
.github/dependabot.yml:40
- This
ignore:
block under the second Docker section also has misaligned indentation. Align it to the same level aslabels:
to ensure the YAML is valid.
ignore:
.github/dependabot.yml:52
- The
ignore:
entry in the third Docker update block is similarly indented incorrectly. It needs to match the indentation of its sibling keys for proper parsing.
ignore:
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6326 +/- ##
==========================================
- Coverage 86.76% 86.74% -0.03%
==========================================
Files 258 258
Lines 11879 11879
==========================================
- Hits 10307 10304 -3
- Misses 1572 1575 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving/merging. I'm not a dependabot expert, so it's not clear to me if or how this will solve the issue, but I see it as a low risk to give it a shot.
@martincostello In the event this PR does not do what's intended maybe it makes sense to remove the weekly schedule temporarily. That might allow you to more quickly iterate on potential solutions. I'd be happy to merge things and give dependabot a kick to see what happens.
Looks like it part-worked. It's bumped the 8.0.x images to the latest patch, but it's not touched the 9.0.x ones. |
#6321 (comment)
Changes
Only update to patch releases when updating Dockerfiles.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes