-
Notifications
You must be signed in to change notification settings - Fork 831
[infra] Add minimum token permissions for all github workflow files #6357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Add minimum token permissions for all github workflow files #6357
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6357 +/- ##
==========================================
+ Coverage 86.69% 86.74% +0.05%
==========================================
Files 258 258
Lines 11850 11850
==========================================
+ Hits 10273 10279 +6
+ Misses 1577 1571 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
@@ -16,6 +16,9 @@ on: | |||
schedule: | |||
- cron: '0 0 * * *' # once in a day at 00:00 | |||
|
|||
permissions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fully support changes, but I do not have yet time to verify changes.
@trask, in this PR you are allowing only read permissions, under the hood otel-bot is used:
What is more around line 125 GH API is called to create release. I am not fully familiar with GH permissions, do you think that it will be working without any problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otelbot has its own token, so these permissions don't affect it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, based on what I have tested in contrib repository it should be fine to merge as is.
See open-telemetry/sig-security#148 for details.
Please check this PR carefully and watch out for any permission-related workflow failures after merging it.
cc @trask