Skip to content

[infra] Add minimum token permissions for all github workflow files #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

opentelemetrybot
Copy link
Collaborator

See open-telemetry/sig-security#148 for details.

Please check this PR carefully and watch out for any permission-related workflow failures after merging it.

cc @trask

@opentelemetrybot opentelemetrybot requested a review from a team as a code owner July 1, 2025 03:49
@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Jul 1, 2025
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (9480cb3) to head (c6ff7e8).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6357      +/-   ##
==========================================
+ Coverage   86.69%   86.74%   +0.05%     
==========================================
  Files         258      258              
  Lines       11850    11850              
==========================================
+ Hits        10273    10279       +6     
+ Misses       1577     1571       -6     
Flag Coverage Δ
unittests-Project-Experimental 86.30% <ø> (-0.18%) ⬇️
unittests-Project-Stable 86.65% <ø> (+0.08%) ⬆️
unittests-Solution 86.64% <ø> (+0.10%) ⬆️
unittests-UnstableCoreLibraries-Experimental 85.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Jul 9, 2025

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jul 9, 2025
@@ -16,6 +16,9 @@ on:
schedule:
- cron: '0 0 * * *' # once in a day at 00:00

permissions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fully support changes, but I do not have yet time to verify changes.
@trask, in this PR you are allowing only read permissions, under the hood otel-bot is used:

What is more around line 125 GH API is called to create release. I am not fully familiar with GH permissions, do you think that it will be working without any problems?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otelbot has its own token, so these permissions don't affect it

@github-actions github-actions bot removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jul 10, 2025
@Kielek Kielek changed the title Add minimum token permissions for all github workflow files [infra] Add minimum token permissions for all github workflow files Jul 17, 2025
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on what I have tested in contrib repository it should be fine to merge as is.

@rajkumar-rangaraj rajkumar-rangaraj merged commit be60150 into open-telemetry:main Jul 24, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants