Skip to content

Commit e6f7c8e

Browse files
authored
otelzap: Add skeleton for array encoder (#5611)
Part of #5191 Pre-work #5279 This PR adds skeleton for arrayEncoder
1 parent c47a69c commit e6f7c8e

File tree

2 files changed

+47
-2
lines changed

2 files changed

+47
-2
lines changed

bridges/otelzap/core.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ func NewCore(name string, opts ...Option) *Core {
101101
}
102102
}
103103

104-
// LevelEnabler decides whether a given logging level is enabled when logging a message.
104+
// Enabled decides whether a given logging level is enabled when logging a message.
105105
func (o *Core) Enabled(level zapcore.Level) bool {
106106
r := log.Record{}
107107
r.SetSeverity(convertLevel(level))

bridges/otelzap/encoder.go

Lines changed: 46 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ import (
1111
"go.opentelemetry.io/otel/log"
1212
)
1313

14-
var _ zapcore.ObjectEncoder = (*objectEncoder)(nil)
14+
var (
15+
_ zapcore.ObjectEncoder = (*objectEncoder)(nil)
16+
_ zapcore.ArrayEncoder = (*arrayEncoder)(nil)
17+
)
1518

1619
// objectEncoder implements zapcore.ObjectEncoder.
1720
// It encodes given fields to OTel key-values.
@@ -146,3 +149,45 @@ func assignUintValue(v uint64) log.Value {
146149
}
147150
return log.Int64Value(int64(v))
148151
}
152+
153+
// arrayEncoder implements [zapcore.ArrayEncoder].
154+
type arrayEncoder struct {
155+
elems []log.Value // nolint:unused
156+
}
157+
158+
// TODO.
159+
func (a *arrayEncoder) AppendArray(v zapcore.ArrayMarshaler) error {
160+
return nil
161+
}
162+
163+
// TODO.
164+
func (a *arrayEncoder) AppendObject(v zapcore.ObjectMarshaler) error {
165+
return nil
166+
}
167+
168+
// TODO.
169+
func (a *arrayEncoder) AppendReflected(v interface{}) error {
170+
return nil
171+
}
172+
173+
// TODO.
174+
func (a *arrayEncoder) AppendComplex128(v complex128) {}
175+
func (a *arrayEncoder) AppendFloat32(v float32) {}
176+
func (a *arrayEncoder) AppendByteString(v []byte) {}
177+
func (a *arrayEncoder) AppendBool(v bool) {}
178+
func (a *arrayEncoder) AppendUint64(v uint64) {}
179+
func (a *arrayEncoder) AppendFloat64(v float64) {}
180+
func (a *arrayEncoder) AppendInt(v int) {}
181+
func (a *arrayEncoder) AppendInt64(v int64) {}
182+
func (a *arrayEncoder) AppendString(v string) {}
183+
func (a *arrayEncoder) AppendComplex64(v complex64) {}
184+
func (a *arrayEncoder) AppendDuration(v time.Duration) {}
185+
func (a *arrayEncoder) AppendInt32(v int32) {}
186+
func (a *arrayEncoder) AppendInt16(v int16) {}
187+
func (a *arrayEncoder) AppendInt8(v int8) {}
188+
func (a *arrayEncoder) AppendTime(v time.Time) {}
189+
func (a *arrayEncoder) AppendUint(v uint) {}
190+
func (a *arrayEncoder) AppendUint32(v uint32) {}
191+
func (a *arrayEncoder) AppendUint16(v uint16) {}
192+
func (a *arrayEncoder) AppendUint8(v uint8) {}
193+
func (a *arrayEncoder) AppendUintptr(v uintptr) {}

0 commit comments

Comments
 (0)