From 7ea51a2c170a949a681e6a28dcce4554bcf94988 Mon Sep 17 00:00:00 2001 From: Robert Pajak Date: Tue, 21 Jan 2025 10:39:46 +0100 Subject: [PATCH] logtest: Add EventName to RecordFactory --- log/logtest/assertions_test.go | 4 ++-- log/logtest/factory.go | 2 ++ log/logtest/factory_test.go | 3 +++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/log/logtest/assertions_test.go b/log/logtest/assertions_test.go index 28e95fe0454..04d62d15d35 100644 --- a/log/logtest/assertions_test.go +++ b/log/logtest/assertions_test.go @@ -16,8 +16,8 @@ func TestAssertRecord(t *testing.T) { AssertRecordEqual(t, r1, r2) now := time.Now() - r1.SetEventName("my event") - r2.SetEventName("my event") + r1.SetEventName("my_event") + r2.SetEventName("my_event") r1.SetTimestamp(now) r2.SetTimestamp(now) r1.SetObservedTimestamp(now) diff --git a/log/logtest/factory.go b/log/logtest/factory.go index afa97d412ea..0c3b389c3dc 100644 --- a/log/logtest/factory.go +++ b/log/logtest/factory.go @@ -14,6 +14,7 @@ import ( // // Do not use RecordFactory to create records in production code. type RecordFactory struct { + EventName string Timestamp time.Time ObservedTimestamp time.Time Severity log.Severity @@ -25,6 +26,7 @@ type RecordFactory struct { // NewRecord returns a log record. func (b RecordFactory) NewRecord() log.Record { var record log.Record + record.SetEventName(b.EventName) record.SetTimestamp(b.Timestamp) record.SetObservedTimestamp(b.ObservedTimestamp) record.SetSeverity(b.Severity) diff --git a/log/logtest/factory_test.go b/log/logtest/factory_test.go index 8cfae272081..084c31bc22f 100644 --- a/log/logtest/factory_test.go +++ b/log/logtest/factory_test.go @@ -15,6 +15,7 @@ import ( func TestRecordFactory(t *testing.T) { now := time.Now() observed := now.Add(time.Second) + evnt := "my_event" severity := log.SeverityDebug severityText := "DBG" body := log.StringValue("Message") @@ -25,6 +26,7 @@ func TestRecordFactory(t *testing.T) { } got := RecordFactory{ + EventName: evnt, Timestamp: now, ObservedTimestamp: observed, Severity: severity, @@ -33,6 +35,7 @@ func TestRecordFactory(t *testing.T) { Attributes: attrs, }.NewRecord() + assert.Equal(t, evnt, got.EventName()) assert.Equal(t, now, got.Timestamp()) assert.Equal(t, observed, got.ObservedTimestamp()) assert.Equal(t, severity, got.Severity())