Skip to content

Commit bab2460

Browse files
authored
Fix span option typo in SDK span End, and WithAttributes only being available on span start (#6006)
1 parent 652588d commit bab2460

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

sdk/trace/span.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -438,8 +438,8 @@ func truncate(limit int, s string) string {
438438
// End ends the span. This method does nothing if the span is already ended or
439439
// is not being recorded.
440440
//
441-
// The only SpanOption currently supported is WithTimestamp which will set the
442-
// end time for a Span's life-cycle.
441+
// The only SpanEndOption currently supported are [trace.WithTimestamp], and
442+
// [trace.WithStackTrace].
443443
//
444444
// If this method is called while panicking an error event is added to the
445445
// Span before ending it and the panic is continued.

trace/config.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ var _ SpanStartEventOption = attributeOption{}
213213

214214
// WithAttributes adds the attributes related to a span life-cycle event.
215215
// These attributes are used to describe the work a Span represents when this
216-
// option is provided to a Span's start or end events. Otherwise, these
216+
// option is provided to a Span's start event. Otherwise, these
217217
// attributes provide additional information about the event being recorded
218218
// (e.g. error, state change, processing progress, system event).
219219
//

0 commit comments

Comments
 (0)