Database semantic convention stability implementation tracking issue

[trask]

Database semantic convention stability implementation tracking issue

• Implement some of the stable database semantic conventions #11575
• Database stable semconv tests and fixes #12601
• Use OTEL_SEMCONV_RC_OPT_IN instead of OTEL_SEMCONV_STABILITY_OPT_IN until database semconv is actually marked stable to avoid confusion(?)
• Deprecate DbClientCommonAttributesGetter #15139
• Consolidate network attribute extraction into DbClientAttributesGetter #15149
• Implement the db.client.operation.duration metric #12802
• Implement the error.type and db.response.status_code attributes  #12804
• Rename db getter methods to match stable semconv naming Rename db getter methods to match stable semconv naming #15696
• Implement the db.query.summary attribute (requires updating the jflex sql parsing) Add support for db.query.summary in SqlClientAttributesExtractor #15971
• Improve coverage for jflex sql parsing
  • SQL summary: support empty statements #15984
  • SQL summary: support line comments #15983
  • SQL sanitization: support PostgreSQL tagged dollar-quoted strings #15979
  • SQL summary: simplify jflex and support a couple of more cases #15986
  • SQL summary: support implicit join after subquery #16007
  • SQL Summary: Support call next value for sequence #15980
  • SQL summary: isolate select state, fix bugs #16017
  • SQL summary: Another jflex simplification #15993
  • SQL summary: handle SQL keywords used as identifiers #16077
  • SQL summary: support CTEs (common table expressions) #16079
  • SQL summary: support LATERAL keyword #16082
  • SQL summary: handle more keywords #16085
  • SQL summary: handle EXPLAIN #16184
  • Add SQL summary edge cases tests #16083
• Implement db.stored_procedure.name Implement db.stored_procedure.name stable semconv attribute #15836
• Extract db.stored_procedure.name from {call procedure_name()} (see Hibernate tests)
• Handle EXEC and EXECUTE in addition to CALL to identify stored procedures Add support for db.query.summary in SqlClientAttributesExtractor #15971
• Implement db.operation.batch.size Instrument jdbc batch queries #12797
• Implement stable span name Implement stable database semconv span name #15854
• Implement Don't capture db.operation.name and db.collection.name from query formats that support multiples semantic-conventions#1566
• Implement Add section on span status for databases semantic-conventions#1560
• Implement Remove redis database index from redis span name semantic-conventions#1565
• Implement Introduce generic operation.summary attribute to represent span name semantic-conventions#1567
• Implement [database] reporting stored procedures/prepared statements semantic-conventions#1491
• Align db.namespace with semconv definitions
  • Follow semconv for SQLServer db.namespace #16080
• Convert connection pool metrics from milliseconds to seconds (Database semantic convention stability implementation tracking issue #12608 (comment))
• Don't sanitize prepared statement text Skip query sanitization for prepared statements under stable semconv flag #15855
• Don't capture db.operation.name, db.collection.name for SQL queries
• Terminology renames (statement -> queryText, dbName -> namespace, operation -> operationName)
  • Database terminology alignment: instrumentation-api-incubator module #16022
  • Database terminology alignment: Redis instrumentation #16023
  • Database terminology alignment: Other modules #16024
  • Continue updating database terminology to match stable semconv (statement -> query) #16074
  • Rename isStatementSanitizationEnabled to isQuerySanitizationEnabled #16133
  • Rename SqlStatementSanitizerUtil → SqlQuerySanitizerUtil #16134
  • Rename internal statementSanitizationEnabled to querySanitizationEnabled #16143
  • Rename remaining statement-related identifiers to query terminology #16144
  • Rename dbName → namespace in internal identifiers #16145
  • More database terminology alignment #16147
  • Rename database semantic convention internal identifiers #16150
  • Rename test variables from dbName to namespace for semantic convention alignment #16151
• Change DbClientAttributesGetter implementations to extend SqlClientAttributesGetter where those modules are leveraging sql sanitization
  • This can only be done after dropping old semconv since it breaks old semconv span names

[zeitlinger]

@trask @laurit which of these items are ready to be implemented?

[trask]

I think most of them, would love your help, pick any and DM me or post on #otel-semconv-db-client-stability with any questions!

[zeitlinger]

OK, I'll try #12802

[stevesea]

is there already a ticket for correcting the units in the hikaricp instrumentation?

in the current agent (2.13.1), hikaricp instrumentation for db.client.connections.{create_time,wait_time,use_time) implements the 1.24.0 semconv and units are 'ms'

1.30.0 semconv changes the units to 's'

[trask]

thanks @stevesea! I've added this to the list above