Skip to content

Remove lowercase normalization for <name> in servlet.request.parameter.<name> #15848

@trask

Description

@trask

Comment says:

// normalize parameter name similarly as is done with header names when header values are
// captured as span attributes
parameterName = parameterName.toLowerCase(Locale.ROOT);

but headers are case insensitive, while request parameter are not, so we shouldn't be normalizing these.

This is currently behind experimental configuration otel.instrumentation.servlet.experimental.capture-request-parameters, so ok to change now, or could defer to 3.0.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    No status

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions