-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export metrics for failed exported logs in BatchLogRecordProcessor #6709
Comments
what should be the metric here - |
hi @harshitrjpt, thanks for checking. |
hmm.. i was thinking- the end user should be worried about the export failure occurrence or how many logs failed to get exported. How should it matter whether 1 log failed to get exported or 10 logs ? |
hi @harshitrjpt Thanks, in some cases, end user need to know how much logs got loss due to export failure. |
@qixiaogang : If that is the use case, then we would just need to define another attribute, similar to 'dropped', for export failure and reuse the same 'processedLogs' metric. But i am still inclined towards tracking export failure occurrence rather than no. of logs that failed to get exported, because the failure is about the exporter and not the logs. |
@qixiaogang I think there is already an existing feature https://github.com/open-telemetry/opentelemetry-java/blob/main/exporters/common/src/main/java/io/opentelemetry/exporter/internal/ExporterMetrics.java you can leverage for your requirement. The ExporterMetrics in generically addresses this need for all exporters.
|
Is your feature request related to a problem? Please describe.
In BatchLogRecordProcessor, it exposed metrics for dropped and exported logs, but didn't expose for failed logs. while export failure is critical and need to expose as metrics.
Describe the solution you'd like
Expose failed export as metrics also.
Describe alternatives you've considered
NA
Additional context
NA
The text was updated successfully, but these errors were encountered: