non-nullable temporality

open-telemetry · Jan 29, 2025 · 178b31a · 178b31a
1 parent 6ae0ffb
commit 178b31a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/SDK/Metrics/MetricMetadataInterface.php b/src/SDK/Metrics/MetricMetadataInterface.php
@@ -22,7 +22,7 @@ public function description(): ?string;
     /**
      * Returns the underlying temporality of this metric.
      *
-     * @return ?Temporality internal temporality
+     * @return Temporality internal temporality
      */
-    public function temporality(): ?Temporality;
+    public function temporality(): Temporality;
 }
diff --git a/tests/Unit/Contrib/Otlp/MetricExporterFactoryTest.php b/tests/Unit/Contrib/Otlp/MetricExporterFactoryTest.php
@@ -58,7 +58,7 @@ public function test_create_with_temporality(array $env, ?Temporality $expected)
 
         $this->assertInstanceOf(AggregationTemporalitySelectorInterface::class, $exporter);
         $metric = $this->createMock(MetricMetadataInterface::class);
-        $metric->method('temporality')->willReturn(null);
+        $metric->method('temporality')->willReturn(Temporality::DELTA);
         $this->assertSame($expected, $exporter->temporality($metric));
     }
 
@@ -85,11 +85,11 @@ public static function temporalityProvider(): array
                 [
                     'OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE' => 'lowmemory',
                 ],
-                null,
+                Temporality::DELTA,
             ],
             'CuMuLaTiVe (mixed case)' => [
                 [
-                    'OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE' => 'cumulative',
+                    'OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE' => 'CuMuLaTiVe',
                 ],
                 Temporality::CUMULATIVE,
             ],