-
Notifications
You must be signed in to change notification settings - Fork 847
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
Depending on how the flask app is instrumented two different counter are initialized for http.server.active_requests metrics.
active_requests_counter = meter.create_up_down_counter(
name=MetricInstruments.HTTP_SERVER_ACTIVE_REQUESTS,
unit="{request}",
description="Number of active HTTP server requests.",
)
vs
active_requests_counter = meter.create_up_down_counter(
name=MetricInstruments.HTTP_SERVER_ACTIVE_REQUESTS,
unit="requests",
description="measures the number of concurrent HTTP requests that are currently in-flight",
)
The first one matches the 1.21.0 spec that we are targeting for stable, but the last one is the one used in auto-instrumentation and should be fixed. BTW other instrumentation are using the helper create_http_server_active_requests from the semconv package.
Spotted by weaver registry live-check.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers