feat: Logs exception when skipping a resource detector

cruisehall · web-flow · commit 4751ba76e1fb · 2025-01-02T22:03:40.000-06:00
Emulates auto-instrumentation log emitted when an instrumentor fails to load https://github.com/open-telemetry/opentelemetry-python-contrib/blob/v0.50b0/opentelemetry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/_load.py#L128
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py
@@ -214,8 +214,11 @@ def create(
                         )
                     ).load()()
                 )
-            except:
-                # TODO emit warning per failed detector?
+            except Exception as exc:  # pylint: disable=broad-exception-caught
+                logger.exception(
+                    "Failed to load resource detector %s, skipping",
+                    entrypoint.name
+                )
                 continue
         resource = get_aggregated_resources(
             resource_detectors, _DEFAULT_RESOURCE

Original file line number	Diff line number	Diff line change
`@@ -214,8 +214,11 @@ def create(`
`214`	`214`	`)`
`215`	`215`	`).load()()`
`216`	`216`	`)`
`217`		`- except:`
`218`		`- # TODO emit warning per failed detector?`
	`217`	`+ except Exception as exc: # pylint: disable=broad-exception-caught`
	`218`	`+ logger.exception(`
	`219`	`+ "Failed to load resource detector %s, skipping",`
	`220`	`+ entrypoint.name`
	`221`	`+ )`
`219`	`222`	`continue`
`220`	`223`	`resource = get_aggregated_resources(`
`221`	`224`	`resource_detectors, _DEFAULT_RESOURCE`