We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N/A
The gRPC channel is not being closed properly, preventing gRPC from shutting down cleanly.
Please refer to: grpc/grpc#38490 (comment)
gRPC cleanly shutting down.
gRPC not cleanly shutting down.
In OTLPExporterMixin, gRPC channel was created directly and passed to _client:
OTLPExporterMixin
_client
opentelemetry-python/exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
Lines 245 to 260 in a7fe4f8
But the channel was not shutdown in shutdown method:
shutdown
Lines 356 to 363 in a7fe4f8
gRPC channel should be closed explicitly with context manager or by calling channel.close() method, example usage: https://github.com/grpc/grpc/blob/822f9b15191840228d17dc0d305887374150150e/examples/python/helloworld/greeter_client.py#L25-L33
channel.close()
If not explicitly closed, the gRPC channel may prevent gRPC from shutting down cleanly, leading to issues like the one described in: grpc/grpc#38490
None
The text was updated successfully, but these errors were encountered:
I guess we a PR with the fix already #4370 😅
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Describe your environment
N/A
What happened?
The gRPC channel is not being closed properly, preventing gRPC from shutting down cleanly.
Steps to Reproduce
Please refer to: grpc/grpc#38490 (comment)
Expected Result
gRPC cleanly shutting down.
Actual Result
gRPC not cleanly shutting down.
Additional context
In
OTLPExporterMixin
, gRPC channel was created directly and passed to_client
:opentelemetry-python/exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
Lines 245 to 260 in a7fe4f8
But the channel was not shutdown in
shutdown
method:opentelemetry-python/exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
Lines 356 to 363 in a7fe4f8
gRPC channel should be closed explicitly with context manager or by calling
channel.close()
method, example usage:https://github.com/grpc/grpc/blob/822f9b15191840228d17dc0d305887374150150e/examples/python/helloworld/greeter_client.py#L25-L33
If not explicitly closed, the gRPC channel may prevent gRPC from shutting down cleanly, leading to issues like the one described in: grpc/grpc#38490
Would you like to implement a fix?
None
The text was updated successfully, but these errors were encountered: