-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs API: LoggerProvider
docs issues
#4318
Labels
Comments
17 tasks
opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py Lines 665 to 681 in a96a3d6
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
LoggerProvider
docs are based on old spec language and should be updated.Specifically:
Identifying parameters - different loggers should be returned if parameters are different
opentelemetry-python/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
Lines 165 to 166 in 59d6754
was changed recently (Define attributes equality and make all fields as identifying for Tracer, Meter, Logger, EventLogger opentelemetry-specification#4161) to make all parameters identifiable and guarantee that different loggers are returned.
the implementation is already compliant, it's just a doc issue.
Logger name should be used as scope name
opentelemetry-python/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
Lines 172 to 176 in 59d6754
Spec language
https://github.com/open-telemetry/opentelemetry-specification/blob/881f364cb5f64f7f276fbe2e69dbc5f2a0d4e76e/specification/logs/api.md#get-a-logger
Recommendation is to change the doc to something like
Attributes are not documented as parameter in
get_logger
APIopentelemetry-python/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
Lines 187 to 188 in 59d6754
Part of open-telemetry/community#1751
The text was updated successfully, but these errors were encountered: