Merge branch 'main' into exp-histogram-improve

Author: xuan-cao-swi

api/opentelemetry-api.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
                ['LICENSE', '.yardopts']
   spec.require_paths = ['lib']
   spec.required_ruby_version = '>= 3.1'
+  spec.add_dependency 'logger'
 
   spec.add_development_dependency 'benchmark-ipsa', '~> 0.2.0'
   spec.add_development_dependency 'bundler', '>= 1.17'

metrics_sdk/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Release History: opentelemetry-metrics-sdk
 
+### v0.11.1 / 2025-11-04
+
+* FIXED: Do not log error when there are no metrics to export
+
 ### v0.11.0 / 2025-10-28
 
 * ADDED: Add logging about export status to Metrics SDK

metrics_sdk/lib/opentelemetry/sdk/metrics/export/periodic_metric_reader.rb

@@ -130,12 +130,7 @@ def export(timeout: nil)
           end
 
           def report_result(result_code)
-            if result_code == Export::SUCCESS
-              OpenTelemetry.logger.debug 'Successfully exported metrics'
-            else
-              OpenTelemetry.handle_error(exception: ExportError.new('Unable to export metrics'))
-              OpenTelemetry.logger.error("Result code: #{result_code}")
-            end
+            OpenTelemetry.logger.debug 'Successfully exported metrics' if result_code == Export::SUCCESS
           end
 
           def lock(&block)

metrics_sdk/lib/opentelemetry/sdk/metrics/version.rb

@@ -8,7 +8,7 @@ module OpenTelemetry
   module SDK
     module Metrics
       # Current OpenTelemetry metrics sdk version
-      VERSION = '0.11.0'
+      VERSION = '0.11.1'
     end
   end
 end

metrics_sdk/test/opentelemetry/sdk/metrics/export/periodic_metric_reader_test.rb

@@ -9,8 +9,6 @@
 describe OpenTelemetry::SDK::Metrics::Export::PeriodicMetricReader do
   PeriodicMetricReader = OpenTelemetry::SDK::Metrics::Export::PeriodicMetricReader
   SUCCESS = OpenTelemetry::SDK::Metrics::Export::SUCCESS
-  FAILURE = OpenTelemetry::SDK::Metrics::Export::FAILURE
-  TIMEOUT = OpenTelemetry::SDK::Metrics::Export::TIMEOUT
 
   class TestExporter
     def initialize(status_codes: nil)
@@ -35,27 +33,6 @@ def shutdown(timeout: nil) = SUCCESS
     def force_flush(timeout: nil) = SUCCESS
   end
 
-  describe 'exporter with failure' do
-    let(:exporter) { TestExporter.new(status_codes: [FAILURE]) }
-    let(:reader) { PeriodicMetricReader.new(exporter: exporter) }
-
-    it 'logs export failure as error' do
-      mock_logger = Minitest::Mock.new
-      mock_logger.expect(:error, nil, [/Unable to export metrics/])
-      mock_logger.expect(:error, nil, [/Result code: 1/])
-
-      # Stub collect to return a non-empty array so export is actually called
-      reader.stub(:collect, ['mock_metric']) do
-        OpenTelemetry.stub(:logger, mock_logger) do
-          reader.force_flush
-        end
-      end
-
-      reader.shutdown
-      mock_logger.verify
-    end
-  end
-
   describe 'succesful exporter' do
     let(:exporter) { TestExporter.new(status_codes: [SUCCESS]) }
     let(:reader) { PeriodicMetricReader.new(exporter: exporter) }

sdk/opentelemetry-sdk.gemspec

@@ -25,6 +25,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
   spec.required_ruby_version = '>= 3.1'
 
+  spec.add_dependency 'logger'
   spec.add_dependency 'opentelemetry-api', '~> 1.1'
   spec.add_dependency 'opentelemetry-common', '~> 0.20'
   spec.add_dependency 'opentelemetry-registry', '~> 0.2'