Skip to content

Commit f3f72ba

Browse files
committed
Move the logs-sdk and metrics-sdk requires
This makes it so the logs and metrics will work when you require like ```ruby require 'opentelemetry/sdk/logs' require 'opentelemetry/sdk/metrics' ``` Without getting 'opentelemetry-logs-api' or 'opentelemetry-logs-metrics' earlier. The opentelemetry-exporter-otlp-logs gem works around this, but I'm leaving that workaround there for now, so it will work with old versions of the opentelemetry-logs-sdk gem that are still locked. [Fixes #1955]
1 parent 1933d4c commit f3f72ba

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

logs_sdk/lib/opentelemetry-logs-sdk.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,4 @@
44
#
55
# SPDX-License-Identifier: Apache-2.0
66

7-
require 'opentelemetry/sdk'
8-
require 'opentelemetry-logs-api'
97
require 'opentelemetry/sdk/logs'

logs_sdk/lib/opentelemetry/sdk/logs.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
#
55
# SPDX-License-Identifier: Apache-2.0
66

7+
require 'opentelemetry/sdk'
8+
require 'opentelemetry-logs-api'
9+
710
require_relative 'logs/version'
811
require_relative 'logs/configurator_patch'
912
require_relative 'logs/logger'

metrics_sdk/lib/opentelemetry-metrics-sdk.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,4 @@
44
#
55
# SPDX-License-Identifier: Apache-2.0
66

7-
require 'opentelemetry/sdk'
8-
require 'opentelemetry-metrics-api'
97
require 'opentelemetry/sdk/metrics'

metrics_sdk/lib/opentelemetry/sdk/metrics.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
#
55
# SPDX-License-Identifier: Apache-2.0
66

7+
require 'opentelemetry/sdk'
8+
require 'opentelemetry-metrics-api'
9+
710
module OpenTelemetry
811
module SDK
912
# The Metrics module contains the OpenTelemetry metrics reference

0 commit comments

Comments
 (0)