Async issues in 0.28

[ShovelJockey]

When using the otlp crate http-proto/reqwest-client and the sdk crate with rt-tokio/experimental trace batch I need to use .with_http_client with the SpanExporterBuilder otherwise the builder fails with NoHttpClient error.

I am using:

Let span_exporter = SpanExporter:builder().with_http().with_export_config(config).build()?

Adding with_http_client(Client::builder().build().unwrap())

Prevents the error but having a look at the code I am not sure why its needed or would a make a difference over the new standard non-async setup.

I am also finding that using a BatchSpanProcessor with the Tokio runtime in tests causes the trace provider shutdown to hang indefinitely.

We are mostly happy at moving to a sync exporter but want to keep the option for an async exporter setup for projects that wont support threading.

[cijothomas]

Can you share a minimal repro for the issue(s) you are observing?

We have added good amount of tests to make sure how hangs/deadlocks occur in shutdowns, but these are only in the newly written BatchProcessor. It is unlikely to be ported to the async based ones. (We do plan to support async runtimes, but it would be likely by modifying the new BatchProcessor implementaions)

[ShovelJockey]

Will have to check as its not my personal code, shutdown works fine when using the tokio current thread runtime however.

Which ultimately should be fine as if we are ok with multi-threading we should use the new sync threaded implementation.

If I am correctly understanding that the difference between tokio and tokio current thread is that the later is single threaded only?

[cijothomas]

If I am correctly understanding that the difference between tokio and tokio current thread is that the later is single threaded only?

I think yes, but I am not an expert in tokio runtimes, so this is better asked to someone more experienced with this.