Skip to content

chore: SpanBuilder API cleanup #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scottgerring opened this issue Mar 31, 2025 · 1 comment
Open

chore: SpanBuilder API cleanup #2886

scottgerring opened this issue Mar 31, 2025 · 1 comment
Assignees
Labels
A-trace Area: issues related to tracing

Comments

@scottgerring
Copy link
Contributor

Parent issue for all of the API cleanup involved with SpanBuilder. As this is mostly going to be coordination (e.g., with tokio-tracing) to confirm we can do it, we should probably track it, and do the actual code changes, in one big hit.

@scottgerring scottgerring added the A-trace Area: issues related to tracing label Mar 31, 2025
@scottgerring scottgerring self-assigned this Mar 31, 2025
@scottgerring scottgerring added this to the Tracing API Stable milestone Mar 31, 2025
@scottgerring
Copy link
Contributor Author

I don't think this makes sense until #2420 , and the associated PoC #1571 , have been done:

  • These APIs can't really be changed until a path away from them for tokio-tracing is provided
  • Where the tokio-tracing/OTel integration lands, and how it looks, determines whether or not the existing integration needs to be changed to do this.

If we land on something that extends Björns PoC for instance and everyone agrees to move towards that, then this dependency will disappear itself. If we don't, the existing integration will need to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trace Area: issues related to tracing
Projects
None yet
Development

No branches or pull requests

1 participant