Skip to content

Commit dc21780

Browse files
committed
Addressing comments
1 parent 4b2fc8c commit dc21780

File tree

2 files changed

+44
-44
lines changed

2 files changed

+44
-44
lines changed

spec-compliance-matrix.md

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ formats is required. Implementing more than one format is optional.
6868
| Unicode support for keys and string values | | + | + | + | + | + | + | + | + | + | + | + |
6969
| [Span linking](specification/trace/api.md#specifying-links) | Optional | Go | Java | JS | Python | Ruby | Erlang | PHP | Rust | C++ | .NET | Swift |
7070
| Links can be recorded on span creation | | + | + | + | + | + | + | + | + | + | + | |
71-
| Links can be recorded after span creation | | + | | | + | | | + | | + | + | |
71+
| Links can be recorded after span creation | | + | | + | + | | | + | | + | + | |
7272
| Links order is preserved | | + | + | + | + | + | + | + | + | + | + | |
7373
| [Span events](specification/trace/api.md#add-events) | Optional | Go | Java | JS | Python | Ruby | Erlang | PHP | Rust | C++ | .NET | Swift |
7474
| AddEvent | | + | + | + | + | + | + | + | + | + | + | + |
@@ -80,13 +80,13 @@ formats is required. Implementing more than one format is optional.
8080
| [Sampling](specification/trace/sdk.md#sampling) | Optional | Go | Java | JS | Python | Ruby | Erlang | PHP | Rust | C++ | .NET | Swift |
8181
| Allow samplers to modify tracestate | | + | + | | + | + | + | + | + | + | + | + |
8282
| ShouldSample gets full parent Context | | + | + | + | + | + | + | + | + | + | - | + |
83-
| Sampler: JaegerRemoteSampler | | + | + | | | | | - | + | | | |
83+
| Sampler: JaegerRemoteSampler | | + | + | + | | | | - | + | | | |
8484
| [New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation) | | + | + | | + | + | + | + | + | + | - | + |
8585
| [IdGenerators](specification/trace/sdk.md#id-generators) | | + | + | + | + | + | + | + | + | + | | + |
8686
| [SpanLimits](specification/trace/sdk.md#span-limits) | X | + | + | + | + | + | + | + | | - | | + |
87-
| [Built-in `SpanProcessor`s implement `ForceFlush` spec](specification/trace/sdk.md#forceflush-1) | | + | + | | + | + | + | + | + | + | + | |
88-
| [Attribute Limits](specification/common/README.md#attribute-limits) | X | + | + | | + | + | + | + | | | | |
89-
| Fetch InstrumentationScope from ReadableSpan | | + | + | | + | | | + | | | | |
87+
| [Built-in `SpanProcessor`s implement `ForceFlush` spec](specification/trace/sdk.md#forceflush-1) | | + | + | + | + | + | + | + | + | + | + | |
88+
| [Attribute Limits](specification/common/README.md#attribute-limits) | X | + | + | + | + | + | + | + | | | | |
89+
| Fetch InstrumentationScope from ReadableSpan | | + | + | + | + | | | + | | | | |
9090
| [Support W3C Trace Context Level 2 randomness](specification/trace/sdk.md#traceid-randomness) | X | - | | | | | | | | | | |
9191
| [TraceIdRatioBased sampler implements OpenTelemetry tracestate `th` field](specification/trace/sdk.md#traceidratiobased) | X | - | | | | | | | | | | |
9292
| [CompositeSampler and built-in ComposableSamplers](specification/trace/sdk.md#compositesampler) | X | - | | | | | | | | | | |
@@ -146,17 +146,17 @@ formats is required. Implementing more than one format is optional.
146146
| The name of the `View` can be specified. | | - | + | + | + | + | + | + | | + | + | |
147147
| The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream. | | + | + | + | + | | + | + | + | + | - | |
148148
| The `View` allows configuring excluded attribute keys of resulting metric stream. | | + | | | | | | | | | | |
149-
| The `View` allows configuring the exemplar reservoir of resulting metric stream. | X | + | - | | - | | - | | | | - | |
149+
| The `View` allows configuring the exemplar reservoir of resulting metric stream. | X | + | - | - | - | | - | | | | - | |
150150
| The SDK allows more than one `View` to be specified per instrument. | X | + | + | + | + | + | + | | + | + | + | |
151151
| The `Drop` aggregation is available. | | + | + | + | + | + | + | | + | + | + | |
152152
| The `Default` aggregation is available. | | + | + | + | + | + | + | | + | + | + | |
153153
| The `Default` aggregation uses the specified aggregation by instrument. | | + | + | + | + | + | + | | + | + | + | |
154154
| The `Sum` aggregation is available. | | + | + | + | + | + | + | + | + | + | + | |
155155
| The `LastValue` aggregation is available. | | + | + | + | + | + | + | + | + | + | + | |
156156
| The `ExplicitBucketHistogram` aggregation is available. | | + | + | + | + | + | + | + | + | + | + | |
157-
| The `ExponentialBucketHistogram` aggregation is available. | | + | | | + | + | | | | | + | |
157+
| The `ExponentialBucketHistogram` aggregation is available. | | + | | + | + | + | | | | | + | |
158158
| The metrics Reader implementation supports registering metric Exporters | | + | + | + | + | + | + | + | + | + | + | |
159-
| The metrics Reader implementation supports configuring the default aggregation on the basis of instrument kind. | | + | + | | + | + | + | | | - | - | |
159+
| The metrics Reader implementation supports configuring the default aggregation on the basis of instrument kind. | | + | + | + | + | + | + | | | - | - | |
160160
| The metrics Reader implementation supports configuring the default temporality on the basis of instrument kind. | | + | + | + | + | + | + | | + | + | | |
161161
| The metrics Exporter has access to the aggregated metrics data (aggregated points, not raw measurements). | | + | + | + | + | + | + | | + | + | + | |
162162
| The metrics Exporter `export` function can not be called concurrently from the same Exporter instance. | | + | + | + | - | + | + | | | + | + | |
@@ -167,19 +167,19 @@ formats is required. Implementing more than one format is optional.
167167
| The metrics Exporter `ForceFlush` can inform the caller whether it succeeded, failed or timed out. | | + | + | + | + | + | + | + | | + | + | |
168168
| The metrics Exporter provides a `shutdown` function. | | + | + | + | + | + | + | + | + | + | + | |
169169
| The metrics Exporter `shutdown` function do not block indefinitely. | | + | + | + | - | | + | | | + | + | |
170-
| The metrics SDK samples `Exemplar`s from measurements. | | + | + | | - | | + | | | | + | |
171-
| Exemplar sampling can be disabled. | | + | - | | - | | + | | | | + | |
172-
| The metrics SDK supports SDK-wide exemplar filter configuration | | + | + | | - | | + | | | | + | |
173-
| The metrics SDK supports `TraceBased` exemplar filter | | + | + | | - | | + | | | | + | |
174-
| The metrics SDK supports `AlwaysOn` exemplar filter | | + | + | | - | | + | | | | + | |
175-
| The metrics SDK supports `AlwaysOff` exemplar filter | | + | + | | - | | + | | | | + | |
176-
| Exemplars retain any attributes available in the measurement that are not preserved by aggregation or view configuration. | | + | + | | - | | + | | | | + | |
177-
| Exemplars contain the associated trace id and span id of the active span in the Context when the measurement was taken. | | + | + | | - | | + | | | | + | |
178-
| Exemplars contain the timestamp when the measurement was taken. | | + | + | | - | | + | | | | + | |
179-
| The metrics SDK provides an `ExemplarReservoir` interface or extension point. | | + | - | | - | | + | + | | | - | |
180-
| An `ExemplarReservoir` has an `offer` method with access to the measurement value, attributes, `Context` and timestamp. | | + | - | | - | | + | + | | | - | |
181-
| The metrics SDK provides a `SimpleFixedSizeExemplarReservoir` that is used by default for all aggregations except `ExplicitBucketHistogram`. | | + | + | | - | | + | + | | | - | |
182-
| The metrics SDK provides an `AlignedHistogramBucketExemplarReservoir` that is used by default for `ExplicitBucketHistogram` aggregation. | | + | + | | - | | + | | | | - | |
170+
| The metrics SDK samples `Exemplar`s from measurements. | | + | + | - | - | | + | | | | + | |
171+
| Exemplar sampling can be disabled. | | + | - | - | - | | + | | | | + | |
172+
| The metrics SDK supports SDK-wide exemplar filter configuration | | + | + | - | - | | + | | | | + | |
173+
| The metrics SDK supports `TraceBased` exemplar filter | | + | + | - | - | | + | | | | + | |
174+
| The metrics SDK supports `AlwaysOn` exemplar filter | | + | + | - | - | | + | | | | + | |
175+
| The metrics SDK supports `AlwaysOff` exemplar filter | | + | + | - | - | | + | | | | + | |
176+
| Exemplars retain any attributes available in the measurement that are not preserved by aggregation or view configuration. | | + | + | - | - | | + | | | | + | |
177+
| Exemplars contain the associated trace id and span id of the active span in the Context when the measurement was taken. | | + | + | - | - | | + | | | | + | |
178+
| Exemplars contain the timestamp when the measurement was taken. | | + | + | - | - | | + | | | | + | |
179+
| The metrics SDK provides an `ExemplarReservoir` interface or extension point. | | + | - | - | - | | + | + | | | - | |
180+
| An `ExemplarReservoir` has an `offer` method with access to the measurement value, attributes, `Context` and timestamp. | | + | - | - | - | | + | + | | | - | |
181+
| The metrics SDK provides a `SimpleFixedSizeExemplarReservoir` that is used by default for all aggregations except `ExplicitBucketHistogram`. | | + | + | - | - | | + | + | | | - | |
182+
| The metrics SDK provides an `AlignedHistogramBucketExemplarReservoir` that is used by default for `ExplicitBucketHistogram` aggregation. | | + | + | - | - | | + | | | | - | |
183183
| A metric Producer accepts an optional metric Filter | | - | | | | | - | | | | | |
184184
| The metric Reader implementation supports registering metric Filter and passing them its registered metric Producers | | - | | | | | - | | | | | |
185185
| The metric SDK's metric Producer implementations uses the metric Filter | | - | | | | | - | | | | | |
@@ -208,7 +208,7 @@ Disclaimer: this list of features is still a work in progress, please refer to t
208208
| OTLP/gRPC exporter | | + | + | + | + | | | + | | + | + | |
209209
| OTLP/HTTP exporter | | + | + | + | + | + | | + | | + | + | |
210210
| OTLP File exporter | | - | - | | - | | | | | + | - | |
211-
| Can plug custom LogRecordExporter | | + | + | | + | + | | + | | + | | |
211+
| Can plug custom LogRecordExporter | | + | + | + | + | + | | + | | + | | |
212212
| Trace Context Injection | | + | + | | + | + | | + | | + | + | |
213213

214214
## Resource

spec-compliance-matrix/js.yaml

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ sections:
114114
- name: Links can be recorded on span creation
115115
status: '+'
116116
- name: Links can be recorded after span creation
117-
status: '?'
117+
status: '+'
118118
- name: Links order is preserved
119119
status: '+'
120120
- heading: '[Span events](specification/trace/api.md#add-events)'
@@ -138,19 +138,19 @@ sections:
138138
- name: ShouldSample gets full parent Context
139139
status: '+'
140140
- name: 'Sampler: JaegerRemoteSampler'
141-
status: '?'
141+
status: '+'
142142
- name: '[New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation)'
143143
status: '?'
144144
- name: '[IdGenerators](specification/trace/sdk.md#id-generators)'
145145
status: '+'
146146
- name: '[SpanLimits](specification/trace/sdk.md#span-limits)'
147147
status: '+'
148148
- name: '[Built-in `SpanProcessor`s implement `ForceFlush` spec](specification/trace/sdk.md#forceflush-1)'
149-
status: '?'
149+
status: '+'
150150
- name: '[Attribute Limits](specification/common/README.md#attribute-limits)'
151-
status: '?'
151+
status: '+'
152152
- name: Fetch InstrumentationScope from ReadableSpan
153-
status: '?'
153+
status: '+'
154154
- name: '[Support W3C Trace Context Level 2 randomness](specification/trace/sdk.md#traceid-randomness)'
155155
status: '?'
156156
- name: '[TraceIdRatioBased sampler implements OpenTelemetry tracestate `th` field](specification/trace/sdk.md#traceidratiobased)'
@@ -260,7 +260,7 @@ sections:
260260
- name: The `View` allows configuring excluded attribute keys of resulting metric stream.
261261
status: '?'
262262
- name: The `View` allows configuring the exemplar reservoir of resulting metric stream.
263-
status: '?'
263+
status: '-'
264264
- name: The SDK allows more than one `View` to be specified per instrument.
265265
status: '+'
266266
- name: The `Drop` aggregation is available.
@@ -276,11 +276,11 @@ sections:
276276
- name: The `ExplicitBucketHistogram` aggregation is available.
277277
status: '+'
278278
- name: The `ExponentialBucketHistogram` aggregation is available.
279-
status: '?'
279+
status: '+'
280280
- name: The metrics Reader implementation supports registering metric Exporters
281281
status: '+'
282282
- name: The metrics Reader implementation supports configuring the default aggregation on the basis of instrument kind.
283-
status: '?'
283+
status: '+'
284284
- name: The metrics Reader implementation supports configuring the default temporality on the basis of instrument kind.
285285
status: '+'
286286
- name: The metrics Exporter has access to the aggregated metrics data (aggregated points, not raw measurements).
@@ -302,37 +302,37 @@ sections:
302302
- name: The metrics Exporter `shutdown` function do not block indefinitely.
303303
status: '+'
304304
- name: The metrics SDK samples `Exemplar`s from measurements.
305-
status: '?'
305+
status: '-'
306306
- name: Exemplar sampling can be disabled.
307-
status: '?'
307+
status: '-'
308308
- name: The metrics SDK supports SDK-wide exemplar filter configuration
309-
status: '?'
309+
status: '-'
310310
- name: The metrics SDK supports `TraceBased` exemplar filter
311-
status: '?'
311+
status: '-'
312312
- name: The metrics SDK supports `AlwaysOn` exemplar filter
313-
status: '?'
313+
status: '-'
314314
- name: The metrics SDK supports `AlwaysOff` exemplar filter
315-
status: '?'
315+
status: '-'
316316
- name: Exemplars retain any attributes available in the measurement that are not preserved by aggregation or view configuration.
317-
status: '?'
317+
status: '-'
318318
- name:
319319
Exemplars contain the associated trace id and span id of the active span in the Context when the measurement was
320320
taken.
321-
status: '?'
321+
status: '-'
322322
- name: Exemplars contain the timestamp when the measurement was taken.
323-
status: '?'
323+
status: '-'
324324
- name: The metrics SDK provides an `ExemplarReservoir` interface or extension point.
325-
status: '?'
325+
status: '-'
326326
- name: An `ExemplarReservoir` has an `offer` method with access to the measurement value, attributes, `Context` and timestamp.
327-
status: '?'
327+
status: '-'
328328
- name:
329329
The metrics SDK provides a `SimpleFixedSizeExemplarReservoir` that is used by default for all aggregations except
330330
`ExplicitBucketHistogram`.
331-
status: '?'
331+
status: '-'
332332
- name:
333333
The metrics SDK provides an `AlignedHistogramBucketExemplarReservoir` that is used by default for `ExplicitBucketHistogram`
334334
aggregation.
335-
status: '?'
335+
status: '-'
336336
- name: A metric Producer accepts an optional metric Filter
337337
status: '?'
338338
- name: The metric Reader implementation supports registering metric Filter and passing them its registered metric Producers
@@ -376,7 +376,7 @@ sections:
376376
- name: OTLP File exporter
377377
status: '?'
378378
- name: Can plug custom LogRecordExporter
379-
status: '?'
379+
status: '+'
380380
- name: Trace Context Injection
381381
status: '?'
382382
- name: Resource

0 commit comments

Comments
 (0)