Skip to content

Commit 8200e2b

Browse files
authored
Merge branch 'main' into jvm_cpu_description
2 parents 975de50 + c5f7a17 commit 8200e2b

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ MISSPELL = $(TOOLS_DIR)/$(MISSPELL_BINARY)
88

99
# see https://github.com/open-telemetry/build-tools/releases for semconvgen updates
1010
# Keep links in semantic_conventions/README.md and .vscode/settings.json in sync!
11-
SEMCONVGEN_VERSION=0.17.0
11+
SEMCONVGEN_VERSION=0.18.0
1212

1313
# TODO: add `yamllint` step to `all` after making sure it works on Mac.
1414
.PHONY: all

internal/tools/schema_check.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
set -e
88

9-
BUILD_TOOL_SCHEMAS_VERSION=0.17.0
9+
BUILD_TOOL_SCHEMAS_VERSION=0.18.0
1010

1111
# List of versions that do not require or have a schema.
1212
declare -a skip_versions=("1.0.0" "1.0.1" "1.1.0" "1.2.0" "1.3.0" "1.6.0")

semantic_conventions/README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ Semantic conventions for the spec MUST adhere to the
1919
[attribute requirement level](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/attribute-requirement-level.md),
2020
and [metric requirement level](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/metric-requirement-level.md) conventions.
2121

22-
Refer to the [syntax](https://github.com/open-telemetry/build-tools/tree/v0.17.0/semantic-conventions/syntax.md)
22+
Refer to the [syntax](https://github.com/open-telemetry/build-tools/tree/v0.18.0/semantic-conventions/syntax.md)
2323
for how to write the YAML files for semantic conventions and what the YAML properties mean.
2424

2525
A schema file for VS code is configured in the `/.vscode/settings.json` of this
2626
repository, enabling auto-completion and additional checks. Refer to
27-
[the generator README](https://github.com/open-telemetry/build-tools/tree/v0.17.0/semantic-conventions/README.md) for what extension you need.
27+
[the generator README](https://github.com/open-telemetry/build-tools/tree/v0.18.0/semantic-conventions/README.md) for what extension you need.
2828

2929
## Generating markdown
3030

@@ -35,7 +35,7 @@ formatted Markdown tables for all semantic conventions in the specification. Run
3535
make table-generation
3636
```
3737

38-
For more information, see the [semantic convention generator](https://github.com/open-telemetry/build-tools/tree/v0.17.0/semantic-conventions)
38+
For more information, see the [semantic convention generator](https://github.com/open-telemetry/build-tools/tree/v0.18.0/semantic-conventions)
3939
in the OpenTelemetry build tools repository.
4040
Using this build tool, it is also possible to generate code for use in OpenTelemetry
4141
language projects.

semantic_conventions/http-common.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ groups:
2525
- id: attributes.http.client
2626
prefix: http
2727
type: attribute_group
28-
brief: 'HTTP Client spans attributes'
28+
brief: 'HTTP client attributes'
2929
attributes:
3030
- ref: server.address
3131
requirement_level: required
@@ -51,7 +51,7 @@ groups:
5151
- id: attributes.http.server
5252
prefix: http
5353
type: attribute_group
54-
brief: 'HTTP Server spans attributes'
54+
brief: 'HTTP server attributes'
5555
attributes:
5656
- id: route
5757
type: string

specification/trace/semantic_conventions/http.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@ and various HTTP versions like 1.1, 2 and SPDY.
5656
HTTP spans MUST follow the overall [guidelines for span names](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#span).
5757
HTTP server span names SHOULD be `{http.request.method} {http.route}` if there is a
5858
(low-cardinality) `http.route` available.
59-
HTTP server span names SHOULD be `{http.method}` if there is no (low-cardinality)
59+
HTTP server span names SHOULD be `{http.request.method}` if there is no (low-cardinality)
6060
`http.route` available.
6161
HTTP client spans have no `http.route` attribute since client-side instrumentation
6262
is not generally aware of the "route", and therefore HTTP client spans SHOULD use
63-
`{http.method}`.
63+
`{http.request.method}`.
6464
Instrumentation MUST NOT default to using URI
6565
path as span name, but MAY provide hooks to allow custom logic to override the
6666
default span name.

specification/trace/semantic_conventions/instrumentation/aws-lambda.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ Function F: | Span Function |
168168
| `cloud.account.id` | | `12345678912` |
169169
| `server.address` | `foo.execute-api.us-east-1.amazonaws.com` | |
170170
| `server.port` | `413` | |
171-
| `http.method` | `GET` | `GET` |
171+
| `http.request.method` | `GET` | `GET` |
172172
| `user_agent.original` | `okhttp 3.0` | `okhttp 3.0` |
173173
| `url.scheme` | | `https` |
174174
| `url.path` | | `/pets/10` |

0 commit comments

Comments
 (0)