Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systematically test ports #6

Open
m-kuhn opened this issue Feb 12, 2024 · 5 comments
Open

Systematically test ports #6

m-kuhn opened this issue Feb 12, 2024 · 5 comments

Comments

@m-kuhn
Copy link
Contributor

m-kuhn commented Feb 12, 2024

For different triplets and with systematic detection of available ports, controlled by a blocklist.
Ideally code from upstream can be reused, see https://github.com/microsoft/vcpkg/blob/master/scripts/azure-pipelines/test-modified-ports.ps1 / ci.baseline.txt.

@Neumann-A
Copy link
Member

Have you tested if https://github.com/open-vcpkg/python-registry/blob/main/ports/vcpkg-python-scripts/import_test.py.in can fail? I had a weird issues while testing stuff like that that the script never seems to fail.

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Mar 6, 2024

At some point during #3 it failed, but maybe in an older version

@Neumann-A
Copy link
Member

Would be good to have an explicitly failing test to make sure the test actual works both ways.

@Neumann-A
Copy link
Member

From microsoft/vcpkg#37409 I noticed that the import test should only run for native builds.

@Neumann-A
Copy link
Member

The import test script should probably be moved into the python3 port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants