pool.c: Remove identical if condition

gruenich · gruenich · commit 8642432b74ec · 2025-05-14T21:31:56.000+02:00
It is always true.
Found by Cppcheck (identicalInnerCondition).
diff --git a/src/pool.c b/src/pool.c
@@ -594,8 +594,7 @@ pool_createwhatprovides(Pool *pool)
     }
   else if (!pool->addedfileprovides && pool->disttype == DISTTYPE_RPM)
     {
-      if (!pool->addedfileprovides)
-	POOL_DEBUG(SOLV_DEBUG_STATS, "WARNING: pool_addfileprovides was not called, this may result in slow operation\n");
+      POOL_DEBUG(SOLV_DEBUG_STATS, "WARNING: pool_addfileprovides was not called, this may result in slow operation\n");
       /* lazyly add file provides */
       for (i = 1; i < num; i++)
 	{

Original file line number	Diff line number	Diff line change
`@@ -594,8 +594,7 @@ pool_createwhatprovides(Pool *pool)`
`594`	`594`	`}`
`595`	`595`	`else if (!pool->addedfileprovides && pool->disttype == DISTTYPE_RPM)`
`596`	`596`	`{`
`597`		`- if (!pool->addedfileprovides)`
`598`		`- POOL_DEBUG(SOLV_DEBUG_STATS, "WARNING: pool_addfileprovides was not called, this may result in slow operation\n");`
	`597`	`+ POOL_DEBUG(SOLV_DEBUG_STATS, "WARNING: pool_addfileprovides was not called, this may result in slow operation\n");`
`599`	`598`	`/* lazyly add file provides */`
`600`	`599`	`for (i = 1; i < num; i++)`
`601`	`600`	`{`