Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude-tag to filter out tags #221

Open
noscript opened this issue Feb 10, 2018 · 5 comments · May be fixed by #357
Open

exclude-tag to filter out tags #221

noscript opened this issue Feb 10, 2018 · 5 comments · May be fixed by #357
Labels
enhancement help wanted

Comments

@noscript
Copy link

Would it be possible to add exclude-tag parameter? Similar to match-tag but to negate the match. Since git 2.13.0 there is --exclude <pattern>.

Why I would need this is to exclude tags that GitHub forcefully creates along with release. I want to avoid @PARENT_TAG@ to match such tags.
@aspiers
Copy link
Member

aspiers commented Feb 10, 2018

Thanks for the suggestion! and yes this sounds like a good idea to me. Shouldn't be hard to do either.

Personally my attention to several other people's tar_scm issues and PRs is long overdue, so I need to spend what little time I have available for tar_scm on those first. But if in the meantime you or anyone else is about to submit a PR for this (including tests of course!), I imagine it would only take a minute or two to review and approve.

@mcepl
Copy link
Contributor

mcepl commented Jan 30, 2019

Is this the problem? When I run periodically osc service run on project from GitHub, I have to remove the git checkout, otherwise it fails with:

➜  neovim osc service run
Detected cached repository...
From https://github.com/neovim/neovim
   6e6bc3b6c..894f6bee5  master     -> origin/master
 ! [rejected]            nightly    -> nightly  (would clobber existing tag)
 ! [rejected]            stable     -> stable  (would clobber existing tag)
ERROR(1): 'From https://github.com/neovim/neovim\n   6e6bc3b6c..894f6bee5  master     -> origin/master\n ! [rejected]            nightly    -> nightly  (would clobber existing tag)\n ! [rejected]            stable     -> stable  (would clobber existing tag)'
Corrupt clone_dir '/home/matej/build/neovim/neovim/neovim' detected.
Please fix corrupt cache directory!
Command failed(1): 'From https://github.com/neovim/neovim\n   6e6bc3b6c..894f6bee5  master     -> origin/master\n ! [rejected]            nightly    -> nightly  (would clobber existing tag)\n ! [rejected]            stable     -> stable  (would clobber existing tag)'
Aborting: service call failed:  /usr/lib/obs/service/obs_scm --versionprefix 0.4.0~git --url https://github.com/neovim/neovim --scm git --changesgenerate enable --outdir /home/matej/build/neovim/neovim/tmpg_o_bkdg.obs_scm.service

@mcepl
Copy link
Contributor

mcepl commented Mar 26, 2020

Personally my attention to several other people's tar_scm issues and PRs is long overdue,

said in 2018 …

@aspiers
Copy link
Member

aspiers commented Mar 26, 2020

Yeah, sorry but I left SUSE 6 months ago and am unlikely to continue working on tar_scm. @adrianschroeter and @M0ses are maintaining it now AFAIK.

@mcepl
Copy link
Contributor

mcepl commented Mar 26, 2020

I understand, I was more teasing you than anything else. Of course, it is sad, that this great company doesn't handle taking over the components after left employees well.

@mcepl mcepl linked a pull request Apr 8, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option exclude-tag which works as a negation of match-tag.
3 participants
@aspiers @mcepl @noscript