Improve the way the beta is checked

Author: hellcp-work

src/api/app/controllers/webui/package_controller.rb

@@ -16,8 +16,7 @@ class Webui::PackageController < Webui::WebuiController
                                        save_person save_group remove_role view_file
                                        buildresult rpmlint_result rpmlint_log rpmlint_summary files]
 
-  before_action :check_scmsync, only: %i[statistics requests]
-  before_action :check_scmsync, only: %i[users], unless: -> { Flipper.enabled?(:scmsync, User.session) }
+  before_action :check_scmsync, only: %i[statistics users requests], unless: -> { action_name == 'users' && Flipper.enabled?(:scmsync, User.session) }
 
   before_action :set_package, only: %i[edit update show requests statistics revisions
                                        branch_diff_info rdiff remove

src/api/app/controllers/webui/webui_controller.rb

@@ -101,7 +101,9 @@ def set_package
     return if @package_name.blank?
 
     begin
-      @package = Package.get_by_project_and_name(@project.name, @package_name, follow_multibuild: true, follow_project_scmsync_links: true)
+      options = { follow_multibuild: true }
+      options[:follow_project_scmsync_links] = true if Flipper.enabled?(:scmsync, User.session)
+      @package = Package.get_by_project_and_name(@project.name, @package_name, options)
     # why it's not found is of no concern
     rescue APIError
       raise Package::UnknownObjectError, "Package not found: #{@project.name}/#{@package_name}"

src/api/app/views/webui/package/_tabs.html.haml

@@ -10,13 +10,15 @@
       - if Flipper.enabled?(:request_show_redesign, User.session)
         = tab_link('RPM Lint', rpmlint_result_path(project, package), 'scrollable-tab-link')
       = tab_link('Revisions', package_view_revisions_path(project, package), 'scrollable-tab-link')
-      - if Flipper.enabled?(:request_index, User.session)
-        = tab_link('Requests', packages_requests_path(project,
-                                                      package,
-                                                      state: %w[new review]),
-                               'scrollable-tab-link', active: controller_name == 'bs_requests')
-      - else
-        = tab_link('Requests', package_requests_path(project, package), 'scrollable-tab-link')
+      - unless package.readonly?
+        - if Flipper.enabled?(:request_index, User.session)
+          = tab_link('Requests', packages_requests_path(project,
+                                                        package,
+                                                        state: %w[new review]),
+                                 'scrollable-tab-link', active: controller_name == 'bs_requests')
+        - else
+          = tab_link('Requests', package_requests_path(project, package), 'scrollable-tab-link')
       = tab_link('Users', package_users_path(project, package), 'scrollable-tab-link')
-      = tab_link('Attributes', index_attribs_path(project, package), 'scrollable-tab-link')
+      - unless package.readonly?
+        = tab_link('Attributes', index_attribs_path(project, package), 'scrollable-tab-link')
       = tab_link('Meta', project_package_meta_path(project, package), 'scrollable-tab-link')